Don't format LRC timestamp with DDdHH:MM:SS #297
Merged
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LRC format generally doesn’t support days and hours because the original format explicitly uses the `[mm:ss.xx]lyric` format. Encoding synchronized lyrics with the current DDdHH:MM:SS format would break certain LRC parsers that weren’t designed to handle hours and days.
|
Looks super fine. Thanks for the PR! |
|
PR has just been shipped with today's v6.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRC format generally doesn’t support days and hours because the original format explicitly uses the
[mm:ss.xx]lyricformat. Encoding synchronized lyrics with the current DDdHH:MM:SS format would break certain LRC parsers that weren’t designed to handle hours and days. For example, the LrcParser used by Jellyfin was using regex to match the mm:ss pattern: https://github.com/kfstorm/LrcParser/blob/95aaffde330efaa252b53654803e7d8794048fc2/LrcParser/LrcFile.cs#L157This PR now formats the timestamps in MM:SS.UUUU format and allows MM to extend beyond double digits when necessary, which should be more compatible than current format.
See jellyfin/jellyfin#13260 for more info