Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Modal #1405

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Components: Modal #1405

merged 1 commit into from
Apr 11, 2023

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Mar 27, 2023

Description

Relates to issue: ZEUS-1391

Simulator Screen Shot - iPhone 11 - 2023-04-08 at 13 44 05
Simulator Screen Shot - iPhone 11 - 2023-04-08 at 13 42 27

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.7.5 milestone Mar 27, 2023
@kaloudis kaloudis marked this pull request as ready for review April 8, 2023 17:45
@kaloudis kaloudis requested a review from shubhamkmr04 April 8, 2023 17:45
@kaloudis kaloudis force-pushed the zeus-1391 branch 3 times, most recently from c13a231 to 6a09050 Compare April 10, 2023 12:07
@ZeusLN ZeusLN deleted a comment from shubhamkmr04 Apr 10, 2023
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modal only pops up for the second time when we specifically tap on the cancel button to close it.

shubhamkmr04
shubhamkmr04 previously approved these changes Apr 10, 2023
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 5e87e09 into ZeusLN:master Apr 11, 2023
@kaloudis kaloudis deleted the zeus-1391 branch April 11, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants