-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera: replace react-native-camera with react-native-camera-kit #1422
Merged
kaloudis
merged 12 commits into
ZeusLN:master
from
shubhamkmr04:shubham/react-native-camera-kit
Apr 8, 2023
Merged
Camera: replace react-native-camera with react-native-camera-kit #1422
kaloudis
merged 12 commits into
ZeusLN:master
from
shubhamkmr04:shubham/react-native-camera-kit
Apr 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloudis
reviewed
Apr 1, 2023
3b1b1e4
to
c97fc51
Compare
c97fc51
to
f2b88db
Compare
f2cee7a
to
a46c599
Compare
kaloudis
reviewed
Apr 5, 2023
kaloudis
reviewed
Apr 5, 2023
a46c599
to
a20ec53
Compare
a910044
to
acc23c6
Compare
kaloudis
reviewed
Apr 7, 2023
895c155
to
d5c22f4
Compare
kaloudis
approved these changes
Apr 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. nice work!
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue: ZEUS-0000
Please enter a description and screenshots, if appropriate, of the work covered in this PR
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: