Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to bevy 0.12 #8

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Upgrade to bevy 0.12 #8

merged 7 commits into from
Nov 8, 2023

Conversation

crillon
Copy link
Contributor

@crillon crillon commented Nov 8, 2023

Updated the bevy and bevy_egui dependencies.
Also fixed several typos and #7.

All tests are green. Examples also work :)

@crillon
Copy link
Contributor Author

crillon commented Nov 8, 2023

Oh, I forget, I'm not sure how to handle the new AssetEvent::LoadedWithDependencies event. At the moment it's being handled the same way as the Added and Modified events. Any thoughts on this?

Details
    let mut changed = HashSet::default();
    let mut removed = Vec::new();
    for event in shader_events.read() {
        match event {
            AssetEvent::Added { id }
            | AssetEvent::Modified { id }
            | AssetEvent::LoadedWithDependencies { id } => {
                changed.insert(id.clone());
            }
            AssetEvent::Removed { id } => {
                changed.remove(id);
                removed.push(id.clone());
            }
        }
    }

0884571#diff-31a275d3425f4b01b1b738927e79db292fc85fdde740a246db7d41bc515ed59cR244-R256

    // Update image bind group cache
    let mut invalid = HashSet::default();
    for event in image_events.read() {
        match event {
            AssetEvent::Added { id }
            | AssetEvent::Modified { id }
            | AssetEvent::Removed { id }
            | AssetEvent::LoadedWithDependencies { id }
                if buffer_images.contains(id) =>
            {
                invalid.insert(id.clone());
            }
            _ => {}
        }
    }

0884571#diff-31a275d3425f4b01b1b738927e79db292fc85fdde740a246db7d41bc515ed59cL265-R281

@Zheoni
Copy link
Owner

Zheoni commented Nov 8, 2023

Thank you so much! I did not have time to update to this release. About the new asset event, I honestly don't know either. We can leave it like this and hope it's the correct decision 😅

I also have a question. What GPU do you have? Since the last update I have swapped my GPU from nvidia to amd, and now I'm getting this error printed every frame, everything works though. It also prints in the old version, so it's not your update.

image

@Zheoni Zheoni merged commit 54a5aed into Zheoni:main Nov 8, 2023
@Zheoni
Copy link
Owner

Zheoni commented Nov 8, 2023

Opened an issue for this #9

@crillon
Copy link
Contributor Author

crillon commented Nov 8, 2023

I have an Nvidia GPU, have no idea what the problem might be :(
Maybe you should create a new issue in the bevy repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants