-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to bevy 0.12 #8
Conversation
Oh, I forget, I'm not sure how to handle the new Details let mut changed = HashSet::default();
let mut removed = Vec::new();
for event in shader_events.read() {
match event {
AssetEvent::Added { id }
| AssetEvent::Modified { id }
| AssetEvent::LoadedWithDependencies { id } => {
changed.insert(id.clone());
}
AssetEvent::Removed { id } => {
changed.remove(id);
removed.push(id.clone());
}
}
} 0884571#diff-31a275d3425f4b01b1b738927e79db292fc85fdde740a246db7d41bc515ed59cR244-R256 // Update image bind group cache
let mut invalid = HashSet::default();
for event in image_events.read() {
match event {
AssetEvent::Added { id }
| AssetEvent::Modified { id }
| AssetEvent::Removed { id }
| AssetEvent::LoadedWithDependencies { id }
if buffer_images.contains(id) =>
{
invalid.insert(id.clone());
}
_ => {}
}
} 0884571#diff-31a275d3425f4b01b1b738927e79db292fc85fdde740a246db7d41bc515ed59cL265-R281 |
Thank you so much! I did not have time to update to this release. About the new asset event, I honestly don't know either. We can leave it like this and hope it's the correct decision 😅 I also have a question. What GPU do you have? Since the last update I have swapped my GPU from nvidia to amd, and now I'm getting this error printed every frame, everything works though. It also prints in the old version, so it's not your update. |
Opened an issue for this #9 |
I have an Nvidia GPU, have no idea what the problem might be :( |
Updated the
bevy
andbevy_egui
dependencies.Also fixed several typos and #7.
All tests are green. Examples also work :)