[Improve][Zeta] Remove assert key words (apache#5947)

Zhouwen-CN · Dec 2, 2023 · dcb4549 · dcb4549
1 parent 8a71b9e
commit dcb4549
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/release-note.md b/release-note.md
@@ -150,6 +150,7 @@
 - [Zeta] Improve Zeta operation max count and ignore NPE (#4787)
 - [Zeta] Remove serialize(deserialize) cost when use shuffle action (#4722)
 - [zeta] Checkpoint exception status messages exclude state data (#5547)
+- [Zeta] Remove assert key words (#5947)
 
 ## Feature
 

diff --git a/...ors-v2/connector-cdc/connector-cdc-base/src/main/java/io/debezium/relational/TableId.java b/...ors-v2/connector-cdc/connector-cdc-base/src/main/java/io/debezium/relational/TableId.java
@@ -20,6 +20,7 @@
 import io.debezium.annotation.Immutable;
 import io.debezium.relational.Selectors.TableIdToStringMapper;
 import io.debezium.schema.DataCollectionId;
+import lombok.NonNull;
 
 import java.io.Serializable;
 
@@ -97,12 +98,11 @@ protected static TableId parse(String[] parts, int numParts, boolean useCatalogB
     public TableId(
             String catalogName,
             String schemaName,
-            String tableName,
+            @NonNull String tableName,
             TableIdToStringMapper tableIdMapper) {
         this.catalogName = catalogName;
         this.schemaName = schemaName;
         this.tableName = tableName;
-        assert this.tableName != null;
         this.id =
                 tableIdMapper == null
                         ? tableId(this.catalogName, this.schemaName, this.tableName)

diff --git a/...er/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java b/...er/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java
@@ -606,7 +606,13 @@ CompletableFuture<PendingCheckpoint> triggerPendingCheckpoint(
             long triggerTimestamp,
             CompletableFuture<Long> idFuture,
             CheckpointType checkpointType) {
-        assert Thread.holdsLock(lock);
+        if (!Thread.holdsLock(lock)) {
+            throw new RuntimeException(
+                    String.format(
+                            "Unsafe invoke, the current thread[%s] has not acquired the lock[%s].",
+                            Thread.currentThread().getName(), this.lock.toString()));
+        }
+
         latestTriggerTimestamp.set(triggerTimestamp);
         return idFuture.thenApplyAsync(
                         checkpointId ->

diff --git a/...er/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java b/...er/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java
@@ -133,7 +133,6 @@ private void getSystemMonitoringInformation(HttpGetCommand command) {
                                     } catch (InterruptedException | ExecutionException e) {
                                         logger.severe("get system monitoring information fail", e);
                                     }
-                                    assert input != null;
                                     String[] parts = input.split(", ");
                                     JsonObject jobInfo = new JsonObject();
                                     Arrays.stream(parts)