Support STM32F3DISCOVERY board #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were mostly copied from the stm32f103 already there.
But this is far from complete, many shortcuts were taken:
- Most importantly,
only a single LED on the board, and its port/pin, is supported,
viz. the 'north' LD3 on bit 9 of GPIOE.
- Setting RCC_AHBENR bit IOPEEN ("I/O port E clock enable") is done
at the same as setting the mode (input or output) on one of its pins.
No idea if that is the right place to do this.
- In cortex-m4.zig, using 'max ram' as the initial stack pointer.
The rest is completely copied from cortex-m3.zig.
- UART test is disabled.
(It seems to assume mbed-lpc1768 pin numbers.)
(How was this code working earlier?!?)
|
For now I don't know how to deal with the duplication between existing CPU file cortex-m3.zig and new cortex-m4.zig: the only difference is the top-of-stack (which actually seems to be part of the chip definition, not the CPU definition), and I don't see how to abstract that out currently. Apart from that, this PR seems pretty complete to me. Removing draft status; let me know if anything else is required. Thanks! |
|
Thanks @MasterQ32 ! |
ikskuh
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: mattnite <mattnite@users.noreply.github.com>
ikskuh
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: mattnite <mattnite@users.noreply.github.com>
ikskuh
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: mattnite <mattnite@users.noreply.github.com>
ikskuh
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: mattnite <mattnite@users.noreply.github.com>
ikskuh
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: mattnite <mattnite@users.noreply.github.com>
ikskuh
pushed a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: mattnite <mattnite@users.noreply.github.com>
mattnite
added a commit
that referenced
this pull request
Feb 26, 2024
mattnite
added a commit
that referenced
this pull request
Feb 26, 2024
mattnite
added a commit
that referenced
this pull request
Feb 26, 2024
mattnite
added a commit
that referenced
this pull request
Feb 26, 2024
mattnite
added a commit
that referenced
this pull request
Mar 1, 2024
mattnite
added a commit
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is my first humble success in the microzig world: a red blinking led on STM32F3DISCOVERY.
Completely incomplete, of course, but it is something. :-)