RP2040 SPI HAL Improvements #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikskuh
requested changes
Jul 27, 2024
|
@ikskuh Requested changes applied! |
ikskuh
approved these changes
Jul 28, 2024
|
For sure! I'll add an example then merge :) |
added 6 commits
July 29, 2024 10:02
- Added support for all SPI modes + bit widths - Implemented TX FIFO "pre-loading" for improved performance
…checks - Other minor odds and ends per PR review
EliSauder
pushed a commit
to EliSauder/microzig
that referenced
this pull request
Aug 27, 2024
- Changed num() to from_instance_number() for clarity - Added support for all SPI modes + bit widths - Implemented TX FIFO "pre-loading" for improved performance - Update example with SPI - Renamed functions to _blocking for consistency among HALs - Changed instance access style - Changed data_width to DataWidthBits to reduce confusion + need for checks - Other minor odds and ends per PR review - Added example of using data width other than 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively minor improvements, but the highlights:
Example transaction before:
Example transaction with preloading (no gap!):
CSNpin automatically is a bit odd, it toggles CSN high after every byte when a GPIO is configured to.spifunction:- For the flash chip I tested this driver on, this would actually make it unusable was I forced to use this
- Instead, I manually drive CSN via a GPIO, which works perfectly well
- Not configuring the GPIOs within the peripheral driver gives users of the HAL this kind of flexibility
The full test suite I wrote for this driver can be found here:
https://github.com/haydenridd/microzig/tree/rp2040-spi