-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rp2xxx: Add support for assembling RP2350-specific PIO #320
Merged
mattnite
merged 31 commits into
ZigEmbeddedGroup:main
from
Grazfather:rp2350_pio_assembler
Jan 17, 2025
Merged
rp2xxx: Add support for assembling RP2350-specific PIO #320
mattnite
merged 31 commits into
ZigEmbeddedGroup:main
from
Grazfather:rp2350_pio_assembler
Jan 17, 2025
+1,997
−1,498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
commented
Dec 19, 2024
Grazfather
force-pushed
the
rp2350_pio_assembler
branch
3 times, most recently
from
December 20, 2024 20:29
6355e52
to
648c840
Compare
Grazfather
changed the title
rp2xxx: Add support for rp2350 assembling
rp2xxx: Add support for assembling RP2350-specific PIO
Dec 20, 2024
Grazfather
force-pushed
the
rp2350_pio_assembler
branch
from
December 26, 2024 17:57
871c34e
to
8b02d19
Compare
Grazfather
force-pushed
the
rp2350_pio_assembler
branch
from
January 6, 2025 17:13
8b02d19
to
4852d4b
Compare
We currently depend on this stuff being comptime, would have to manage the memory if we wanted to support it running at runtime This reverts commit dc3b857.
Grazfather
force-pushed
the
rp2350_pio_assembler
branch
from
January 16, 2025 00:34
f3c9a4d
to
a2900f0
Compare
Grazfather
force-pushed
the
rp2350_pio_assembler
branch
from
January 16, 2025 00:36
a2900f0
to
e807673
Compare
Grazfather
force-pushed
the
rp2350_pio_assembler
branch
from
January 16, 2025 01:01
2e28677
to
3349843
Compare
Grazfather
commented
Jan 16, 2025
Grazfather
commented
Jan 16, 2025
Grazfather
commented
Jan 16, 2025
Grazfather
force-pushed
the
rp2350_pio_assembler
branch
from
January 16, 2025 01:16
3349843
to
9186848
Compare
@Grazfather there's one item unchecked, I take it you forgot to check it? |
@mattnite I don't understand that one. I don't see any difference in the encoding of the (plain) |
mattnite
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RP2350 adds the following new instruction features:
PINDIRS, ~NULL
[ ] Adds SM IRQ flags as a source for MOV x, STATUSblocks.
machines on the next cycle.
scratch register.
RP2350 adds the following security features:
Secure GPIO returns a 0.
permit Non-secure access according to ACCESSCTRL) and Secure-only blocks (those which do not).
RP2350 includes the following general improvements: