Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameters for strip-jar goal: zipDateTime and zipDateTimeFormatPattern #20

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Conversation

aksian
Copy link
Contributor

@aksian aksian commented Apr 29, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 94.752% when pulling 0e34893 on aksian:master into a01db45 on Zlika:master.

@Zlika Zlika merged commit 60f707c into Zlika:master Apr 30, 2018
@Zlika
Copy link
Owner

Zlika commented Apr 30, 2018

Great PR, thanks!

@aksian
Copy link
Contributor Author

aksian commented Apr 30, 2018

You are welcome :)
BTW, maybe you'd better remove the lines "<phase>package</phase>" from my example. They accidentally stayed out of my own project, where I needed to get the result exactly at the package phase. This can become a source of surprises, and, in general, it is better for most users not to play with the plugins execution order...

@Zlika
Copy link
Owner

Zlika commented Apr 30, 2018

Ok I will do that.
I know that using pre-integration-test as the default phase for strip:jar may not be ideal, but it's the only way I found to be sure that it will be executed after jar:jar.

@aksian
Copy link
Contributor Author

aksian commented Apr 30, 2018

In fact, this is quite a reasonable compromise. Nobody forbids changing the default settings :)

@Zlika Zlika added this to the 0.6 milestone Apr 30, 2018
@Zlika
Copy link
Owner

Zlika commented Apr 30, 2018

As I don't have anything else in the pipeline at this time, I released version 0.6 of the plugin with your PR.
Thank you for this feature.

@aksian
Copy link
Contributor Author

aksian commented May 1, 2018

Thank you for such a quick release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants