Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize assembly solvers #1268

Merged
merged 15 commits into from
Mar 28, 2023
Merged

Optimize assembly solvers #1268

merged 15 commits into from
Mar 28, 2023

Conversation

dark64
Copy link
Member

@dark64 dark64 commented Jan 26, 2023 •
edited
Loading

  • Changed a file structure to a section-based one
  • Moved zir solver to a separate section of the file to improve output size and performance
  • Optimized evaluation of linear combinations in the interpreter (~15-20% faster)

@dark64 dark64 mentioned this pull request Jan 31, 2023
Closed
@dark64 dark64 marked this pull request as ready for review February 28, 2023 10:38
dark64
dark64 commented Feb 28, 2023
View reviewed changes
zokrates_codegen/src/lib.rs Outdated Show resolved Hide resolved
Schaeff
Schaeff requested changes Mar 8, 2023
View reviewed changes
zokrates_ast/src/zir/substitution.rs Outdated Show resolved Hide resolved
zokrates_ast/src/ir/serialize.rs Outdated Show resolved Hide resolved
zokrates_ast/src/ir/serialize.rs Outdated Show resolved Hide resolved
zokrates_ast/src/ir/serialize.rs Outdated Show resolved Hide resolved
zokrates_ast/src/ir/solver_indexer.rs Outdated Show resolved Hide resolved
zokrates_ast/src/ir/from_flat.rs Show resolved Hide resolved
zokrates_ast/src/zir/identifier.rs Outdated Show resolved Hide resolved
zokrates_ast/src/zir/substitution.rs Outdated Show resolved Hide resolved
zokrates_ast/src/zir/substitution.rs Outdated Show resolved Hide resolved
zokrates_codegen/src/lib.rs Outdated Show resolved Hide resolved
@dark64 dark64 requested a review from Schaeff March 21, 2023 12:20
Schaeff
Schaeff reviewed Mar 24, 2023
View reviewed changes
Copy link
Member

@Schaeff Schaeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small naming nitpick!

zokrates_codegen/src/lib.rs Outdated Show resolved Hide resolved
@dark64 dark64 requested a review from Schaeff March 28, 2023 13:04
@Schaeff Schaeff merged commit 3ffd642 into develop Mar 28, 2023
@Schaeff Schaeff deleted the optimize-zir-solver branch March 28, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schaeff Schaeff Schaeff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dark64 @Schaeff