Improve setup FFI in zokrates-js #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1276
This issue seems to be because we are serializing the setup keypair directly to
JsValue. When callingJsValue::from_serde, the function will serialize the provided value to a JSON string, send the JSON string to JS, parse it into a JS object, and then return a handle to the JS object.This is fine in most cases, but in some extreme cases with circuits that end up with a large proving key, this serialization method would fail because of a large JSON string that gets produced. This PR solves this issue with the same method we use for compilation artifacts.