Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize backend integrations #1289

Merged
merged 11 commits into from
Apr 11, 2023
Merged

Optimize backend integrations #1289

merged 11 commits into from
Apr 11, 2023

Conversation

dark64
Copy link
Member

@dark64 dark64 commented Mar 24, 2023 •
edited
Loading

  • Changed witness format to a binary one
  • Added --json flag to compute-witness for debugging purposes
  • Removed unnecessary into_canonical calls
  • Improved performance of into_bellman calls

@dark64 dark64 marked this pull request as ready for review April 4, 2023 17:18
@dark64 dark64 requested a review from Schaeff April 4, 2023 17:18
Schaeff
Schaeff reviewed Apr 8, 2023
View reviewed changes
zokrates_ast/src/common/variable.rs Outdated Show resolved Hide resolved
zokrates_ast/src/ir/witness.rs Outdated Show resolved Hide resolved
zokrates_ast/src/ir/witness.rs Show resolved Hide resolved
@dark64 dark64 requested a review from Schaeff April 11, 2023 13:35
@Schaeff Schaeff merged commit 10ebd60 into develop Apr 11, 2023
@Schaeff Schaeff deleted the backend-opt branch April 11, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schaeff Schaeff Schaeff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dark64 @Schaeff