New Release #113
New Release #113
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| static bool tx_initialized = false; | ||
|
|
||
| __Z_INLINE bool process_chunk(__Z_UNUSED volatile uint32_t *tx, uint32_t rx) { | ||
| // FIXME: correct/improve this. Move to common? |
Check notice
Code scanning / CodeQL
FIXME comment Note
| @@ -19,19 +19,23 @@ | |||
| // CRYPTO File | |||
| #define CHECKSUM_LENGTH 4 | |||
|
|
|||
| #define ED25519_SK_SIZE 64 | |||
|
|
|||
| // FIXME: there is a difference in the seed size with rust | |||
Check notice
Code scanning / CodeQL
FIXME comment Note
| // uint16_t fp_uint64_to_str(char *out, uint16_t outLen, const uint64_t value, uint8_t decimals) { | ||
| // return fpuint64_to_str(out, outLen, value, decimals); | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| @@ -1094,7 +1091,7 @@ | |||
| for (uint8_t i = 0; i < tInListLen; i++) { | |||
| const t_input_item_t *item = t_inlist_retrieve_item(i); | |||
|
|
|||
| CATCH_CXERROR(os_derive_bip32_no_throw(CX_CURVE_256K1, item->path, HDPATH_LEN_DEFAULT, privateKeyData, NULL)); | |||
| CATCH_CXERROR(os_derive_bip32_no_throw(CX_CURVE_256K1, item->path, HDPATH_LEN_BIP44, privateKeyData, NULL)); | |||
Check warning
Code scanning / CodeQL
Implicit function declaration Warning
| @@ -1094,7 +1091,7 @@ | |||
| for (uint8_t i = 0; i < tInListLen; i++) { | |||
| const t_input_item_t *item = t_inlist_retrieve_item(i); | |||
|
|
|||
| CATCH_CXERROR(os_derive_bip32_no_throw(CX_CURVE_256K1, item->path, HDPATH_LEN_DEFAULT, privateKeyData, NULL)); | |||
| CATCH_CXERROR(os_derive_bip32_no_throw(CX_CURVE_256K1, item->path, HDPATH_LEN_BIP44, privateKeyData, NULL)); | |||
Check warning
Code scanning / CodeQL
Implicit function declaration Warning
|
|
||
| zxerr_t error = zxerr_unknown; | ||
| io_seproxyhal_io_heartbeat(); | ||
| CATCH_CXERROR( | ||
| os_derive_bip32_with_seed_no_throw(HDW_NORMAL, CX_CURVE_Ed25519, path, HDPATH_LEN_DEFAULT, sk, NULL, NULL, 0)); | ||
| CATCH_CXERROR(os_derive_bip32_with_seed_no_throw(HDW_NORMAL, CX_CURVE_Ed25519, path, HDPATH_LEN_BIP44, raw_privkey, NULL, |
Check warning
Code scanning / CodeQL
Implicit function declaration Warning
| *flags |= IO_ASYNCH_REPLY; | ||
| } | ||
|
|
||
| __Z_INLINE void handleCheckandSign(volatile uint32_t *tx, uint32_t rx) { |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
| switch (hdPath.addressKind) { | ||
| case addr_sapling_div: | ||
| snprintf(outKey, outKeyLen, "Divisifier"); | ||
| array_to_hexstr(outVal, outValLen, hdPath.saplingdiv_div, DIV_SIZE); | ||
| return zxerr_ok; | ||
|
|
||
| default: | ||
| return zxerr_no_data; | ||
| } |
Check notice
Code scanning / CodeQL
No trivial switch statements Note
| cx_ecfp_public_key_t cx_publicKey = {0}; | ||
| cx_ecfp_private_key_t cx_privateKey = {0}; | ||
| uint8_t privateKeyData[64] = {0}; | ||
|
|
||
| zxerr_t error = zxerr_unknown; | ||
| CATCH_CXERROR(os_derive_bip32_no_throw(CX_CURVE_256K1, hdPath, HDPATH_LEN_DEFAULT, privateKeyData, NULL)); | ||
| CATCH_CXERROR(os_derive_bip32_no_throw(CX_CURVE_256K1, hdPath.secp256k1_path, HDPATH_LEN_BIP44, privateKeyData, NULL)); |
Check warning
Code scanning / CodeQL
Implicit function declaration Warning
| cx_ecfp_public_key_t cx_publicKey = {0}; | ||
| cx_ecfp_private_key_t cx_privateKey = {0}; | ||
| uint8_t privateKeyData[64] = {0}; | ||
|
|
||
| zxerr_t error = zxerr_unknown; | ||
| CATCH_CXERROR(os_derive_bip32_no_throw(CX_CURVE_256K1, hdPath, HDPATH_LEN_DEFAULT, privateKeyData, NULL)); | ||
| CATCH_CXERROR(os_derive_bip32_no_throw(CX_CURVE_256K1, hdPath.secp256k1_path, HDPATH_LEN_BIP44, privateKeyData, NULL)); |
Check warning
Code scanning / CodeQL
Implicit function declaration Warning
* fix: Update test vector addresses for sapling senders and outputs Update snapshots feat: Update builder tests in rust to use new addresses fix transactions and add new production makefile rule Update tests and snapshots Update deps in zcashtools package * Enable all targets * feat: change app name (#112) * Update snapshots Increate timeout Update snapshots Fix approval for stax target * Run test concurrently * feat: update app version and snapshots * feat: update a few more snapshots * feat: update a few more snapshots --------- Co-authored-by: Emmanuel <emmanuelm41@gmail.com>
Waiting for #111 to be merged
🔗 zboto Link