[Chore] Upgrade node version to support vite eslint packages #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
acridlier
approved these changes
Jan 17, 2025
.nvmrc
Outdated
| @@ -1 +1 @@ | |||
| v18.14.0 | |||
| v18.20.5 | |||
There was a problem hiding this comment.
good first step, could you see if v22 would work out of the box?
v18 is in maintenance mode and this will stop middle of this year
There was a problem hiding this comment.
Good point. v22 also works fine. Also noticed github actions also runs in v18. Upgraded as well but require approval from a maintainer https://github.com/Zuehlke/poinz/actions/runs/12840377319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: eslint related packages generated by vite frontend tooling is unsupported due to old node version declared in .nvmrc (see image below). This bump is to resolve the warnings.
Ran unit tests, e2e tests, build and docker image build scripts. all works fine.