Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unusual sector sizes #338

Closed
wohali opened this issue Nov 24, 2023 · 3 comments
Closed

Support unusual sector sizes #338

wohali opened this issue Nov 24, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@wohali
Copy link

wohali commented Nov 24, 2023

Symbolics Lisp machines require an unusual disk sector size: 1280 bytes.

Currently the firmware does not support this.

Can support be added for unusual sector sizes please? Otherwise, the device is not usable in these machines.

@aperezbios aperezbios added the enhancement New feature or request label Nov 25, 2023
@connorwk
Copy link

FWIW I simply removed the if statement, compiled and threw it on my device and it works great now with 1280 byte blocks on the Symbolics XL1200 I have.
I was also able to modify an image file from a SCSI2SD which rounds its stored blocks to the nearest 512bytes, so it was 1536 bytes per block with a padded 256 bytes at the end. Removed the padding for every block and it works great on the zuluscsi now.

An if statement blocking support for certain block sizes when the code seems to support it no issue seems counterintuitive.
If you're going to have a supported list at-least having it documented would be handy.
Maybe just throw a loud warning in the log if you see a block size your not expecting to help point folks in the right direction.

Another point brought up while discussing this with others are block sizes like 520 byte block sizes, used by IBM.

morio added a commit that referenced this issue Mar 19, 2024
Addressing issue: #338

Allowing block sizes from 8 bytes to 64kB
@aperezbios
Copy link
Collaborator

@wohali here's a build for you to test whenever you have some time
ZuluSCSI-firmware-arbitrary-block-sizes-test.zip

@wohali
Copy link
Author

wohali commented Mar 29, 2024

Thanks @aperezbios this looks to resolve the issue.

@wohali wohali closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants