Fix device type for IMG0-9 #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for issue #345 The bug was introduced in https://github.com/ZuluSCSI/ZuluSCSI-firmware/releases/tag/v2023.10.20 This fixes an issue when the device specific options in the `zuluscsi.ini` file `IMG0`-`IMG9` are set along with `Type` set to anything besides 0. The type would be ignored and the device would always be set to a fixed device (Type=0). The underlying fix was to add a new device type `S2S_CFG_NOT_SET`, which is only used in initialization to determine where the device type should be overwritten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #345 The bug was introduced in https://github.com/ZuluSCSI/ZuluSCSI-firmware/releases/tag/v2023.10.20
This fixes an issue when the device specific options in the
zuluscsi.inifileIMG0-IMG9are set along withTypeset to anything besides 0. The type would be ignored and the device would always be set to a fixed device (Type=0).The underlying fix was to add a new device type
S2S_CFG_NOT_SET, which is only used in initialization to determine where the device type should be overwritten.