Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[FEATURE] Path for win bin download #333

Merged
merged 14 commits into from
Jul 31, 2020
Merged

[FEATURE] Path for win bin download #333

merged 14 commits into from
Jul 31, 2020

Conversation

ernelio
Copy link
Contributor

@ernelio ernelio commented Jul 30, 2020 •
edited
Loading

- What I did

  • Add path https://commons-repo.ritchiecli.io/latest/ritchiecli.msi

- How to verify it

  • Generate release or run pipeline qa
  • in qa https://ritchie-cli-bucket234376412767550.s3-sa-east-1.amazonaws.com/latest/ritchiecli.msi
  • in release https://commons-repo.ritchiecli.io/latest/ritchiecli.msi

- Description for the changelog

  • Add path https://commons-repo.ritchiecli.io/latest/ritchiecli.msi

@ernelio
Copy link
Contributor Author

ernelio commented Jul 30, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 30, 2020

👌 Merged branch feature/packaging-v2 into qa

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020 •
edited
Loading

Codecov Report

Merging #333 into ritchie-2.0.0 will decrease coverage by 0.05%.
The diff coverage is 25.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ritchie-2.0.0     #333      +/-   ##
=================================================
- Coverage          65.21%   65.16%   -0.06%     
=================================================
  Files                 78       78              
  Lines               2550     2552       +2     
=================================================
  Hits                1663     1663              
- Misses               725      727       +2     
  Partials             162      162
Impacted Files Coverage Δ
pkg/credential/finder.go 68.42% <ø> (ø)
pkg/credential/settings.go 84.76% <0.00%> (-1.65%) ⬇️
pkg/version/version.go 88.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1864e...22ef5f7. Read the comment docs.

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ernelio ernelio changed the title fix sign [FEATURE] Path for win bin download Jul 31, 2020
@ernelio ernelio added the 2.0.0 label Jul 31, 2020
@ernelio ernelio self-assigned this Jul 31, 2020
@ernelio ernelio added the 💠 Windows This issue or pull request is specific to the Windows operating system label Jul 31, 2020
@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

@ernelio
Copy link
Contributor Author

ernelio commented Jul 31, 2020

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Jul 31, 2020

👌 Merged branch feature/packaging-v2 into qa

sandokandias
sandokandias approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@sandokandias sandokandias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernelio ernelio merged commit cef606c into ZupIT:ritchie-2.0.0 Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandokandias sandokandias sandokandias approved these changes

Assignees

@ernelio ernelio

Labels
💠 Windows This issue or pull request is specific to the Windows operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ernelio @codecov-commenter @sandokandias