Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix linter #346

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Fix linter #346

merged 1 commit into from
Aug 4, 2020

Conversation

victor-schumacher
Copy link
Contributor

- What I did
Changed exit code since it was not breaking pipeline when find a issue

- Description for the changelog

Changed exit code since it was not breaking pipeline when find a issue

@victor-schumacher victor-schumacher linked an issue Aug 3, 2020 that may be closed by this pull request
@victor-schumacher victor-schumacher self-assigned this Aug 3, 2020
@victor-schumacher victor-schumacher added the 🪲 bug Report a bug encountered while operating Ritchie label Aug 3, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #346 into ritchie-2.0.0 will decrease coverage by 0.20%.
The diff coverage is 72.27%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ritchie-2.0.0     #346      +/-   ##
=================================================
- Coverage          65.21%   65.00%   -0.21%     
=================================================
  Files                 78       78              
  Lines               2550     2555       +5     
=================================================
- Hits                1663     1661       -2     
- Misses               725      730       +5     
- Partials             162      164       +2     
Impacted Files Coverage Δ
pkg/cmd/build_formula.go 0.00% <0.00%> (ø)
pkg/cmd/root.go 0.00% <0.00%> (ø)
pkg/credential/finder.go 68.42% <ø> (ø)
pkg/credential/settings.go 84.76% <0.00%> (-1.65%) ⬇️
pkg/formula/builder/bat.go 0.00% <0.00%> (ø)
pkg/formula/builder/docker.go 0.00% <0.00%> (ø)
pkg/formula/builder/local.go 72.54% <ø> (ø)
pkg/formula/formula.go 90.90% <ø> (ø)
pkg/formula/runner/post_run.go 50.00% <ø> (ø)
pkg/cmd/list_credential.go 80.00% <50.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd0da0...3f36bd7. Read the comment docs.

@sandokandias sandokandias merged commit dae92e1 into ZupIT:ritchie-2.0.0 Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug Report a bug encountered while operating Ritchie
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] lint doesn't fail pipeline when find issue
4 participants