This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Asking for credential during formula runtime #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> [Enhancement] Ask for credential during formula runtime#
henriquemoraes8
force-pushed
the
enhancement/credential-dynamic-prompt
branch
from
471902b
to
44e0793
Compare
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
+ Coverage 65.62% 65.84% +0.21%
==========================================
Files 80 81 +1
Lines 2720 2743 +23
==========================================
+ Hits 1785 1806 +21
Misses 751 751
- Partials 184 186 +2
Continue to review full report at Codecov.
|
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
brunasilvazup
changed the title
brunasilvazup
added
waiting reply
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
brunasilvazup
suggested changes
Aug 17, 2020
brunasilvazup
added
waiting reply
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Actually removing test files
henriquemoraes8
force-pushed
the
enhancement/credential-dynamic-prompt
branch
from
0cc1b76
to
fd3dd12
Compare
brunasilvazup
requested review from
brunasilvazup,
kaduartur,
lucasdittrichzup and
victor-schumacher
lucasdittrichzup
previously approved these changes
Aug 18, 2020
Signed-off-by: Henrique Moraes <henrique.rusca@gmail.com>
brunasilvazup
approved these changes
Aug 21, 2020
lucasdittrichzup
approved these changes
Aug 24, 2020
|
/merge qa |
|
/merge qa |
|
👌 Merged branch enhancement/credential-dynamic-prompt into qa |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user executes a formula that requires credentials, it halts demanding her to set the credentials through the
rit set credentialcommand. This behavior may affect the user experience especially in case of custom credentials.The idea is to detect the credential keys that have not been set and ask for them during runtime.
Discussion
A user may never require to understand how credentials work in Ritchie if he just fills correctly when required. This feature works as an abstraction for those who just want to use the cli without worrying too much about its mechanics.
This will work even for custom credentials or multi-field providers. It records the prompted value as if the user run
rit set credentialIt does not create the provider in case it does not exist. The user should manually set a custom provider.
This will record even if the
config.jsonfile has a typo on either the provider or the keyHow to verify it
Run a formula that requires credentials without having them set
Description for the changelog
Credentials are asked during formula runtime in case they were not set
The example below shows the behavior running
rit aws create bucketwithout previously having any credential set