Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Collect Product Metrics #449

Merged
merged 55 commits into from
Aug 21, 2020
Merged

Collect Product Metrics #449

merged 55 commits into from
Aug 21, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did

  • Add new command rit metrics to enable and disable send metrics
  • Add new question about sending metric on init command
  • Create a client to send metric

- How to verify it

  • Run unit tests make unit-test
  • Build this branch and run rit init and rit metrics

- Description for the changelog
Collect Product Metrics for V2

kaduartur and others added 30 commits August 7, 2020 15:25
[FEATURE] Create interface for metrics
[FEATURE] Create implementation to UserIdGenerator
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…stomMock

Improves inputListCustomMock to use a custom function
Signed-off-by: victor-schumacher <victor.schumacher@zup.com.br>
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
add mock for check metrics
changed tests for metrics cmd
change MetricsPath() function to a var called FilePath

Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…init

Adds question about metrics in init
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
@kaduartur kaduartur added the ✨ feature Suggest a new feature or enhancement to the Ritchie project label Aug 18, 2020
@kaduartur kaduartur added this to the 2.0.4 milestone Aug 18, 2020
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #449 into master will increase coverage by 0.64%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   66.19%   66.84%   +0.64%     
==========================================
  Files          80       87       +7     
  Lines        2754     2874     +120     
==========================================
+ Hits         1823     1921      +98     
- Misses        746      759      +13     
- Partials      185      194       +9     
Impacted Files Coverage Δ
pkg/metric/user_id_generator.go 63.63% <63.63%> (ø)
pkg/metric/http_sender.go 69.23% <69.23%> (ø)
pkg/cmd/init.go 77.98% <91.66%> (-10.53%) ⬇️
pkg/cmd/metrics.go 100.00% <100.00%> (ø)
pkg/metric/checker.go 100.00% <100.00%> (ø)
pkg/metric/data_collector.go 100.00% <100.00%> (ø)
pkg/metric/grpc_sender.go 100.00% <100.00%> (ø)
pkg/metric/metric.go 100.00% <100.00%> (ø)
pkg/version/version.go 88.46% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9f28e...fd12cd1. Read the comment docs.

@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Aug 19, 2020

👌 Merged branch feature/metrics into qa

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
@kaduartur kaduartur added the QA label Aug 20, 2020
@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Aug 20, 2020

👌 Merged branch feature/metrics into qa

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
@kaduartur
Copy link
Contributor Author

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Aug 20, 2020

👌 Merged branch feature/metrics into qa

@kaduartur kaduartur merged commit 838aaa7 into master Aug 21, 2020
@kaduartur kaduartur deleted the feature/metrics branch August 21, 2020 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants