This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Added step to question about formula found #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
brunats
force-pushed
the
fix/order-of-choice-of-formula-for-the-build
branch
from
01b7b8a
to
84da419
Compare
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=======================================
Coverage 69.03% 69.03%
=======================================
Files 88 88
Lines 2955 2955
=======================================
Hits 2040 2040
Misses 717 717
Partials 198 198 Continue to review full report at Codecov.
|
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…r-of-choice-of-formula-for-the-build Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…r-of-choice-of-formula-for-the-build Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
brunasilvazup
requested review from
kaduartur,
victor-schumacher and
lucasdittrichzup
brunasilvazup
added
✔️ ready-for-review
Comment on lines
+197
to
+214
| func getFields(fieldsDefault fieldsTestBuildFormulaCmd, fieldsTest fieldsTestBuildFormulaCmd) fieldsTestBuildFormulaCmd { | ||
| var fields fieldsTestBuildFormulaCmd = fieldsDefault | ||
|
|
||
| if fieldsTest.directory != nil { | ||
| fields.directory = fieldsTest.directory | ||
| } | ||
| if fieldsTest.inList != nil { | ||
| fields.inList = fieldsTest.inList | ||
| } | ||
| if fieldsTest.localBuilder != nil { | ||
| fields.localBuilder = fieldsTest.localBuilder | ||
| } | ||
| if fieldsTest.workspaceManager != nil { | ||
| fields.workspaceManager = fieldsTest.workspaceManager | ||
| } | ||
|
|
||
| return fields | ||
| } |
There was a problem hiding this comment.
This function is used to always choose the default fields and if the test defines any field, use the test field.
The d5b81bc commit is the one with just that change.
brunasilvazup
requested review from
lucasdittrichzup
and removed request for
lucasdittrichzup
lucasdittrichzup
approved these changes
Aug 31, 2020
|
/merge qa |
|
👌 Merged branch fix/order-of-choice-of-formula-for-the-build into qa |
|
Qa tests:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a new step in choosing the formula for the build.
When rit finds a directory with a formula, it looks for other formulas in the tree (within the same directory).
If he finds it, he asks the user if he wants to select this formula found or continue searching for another one.
- How to verify it
git fetch upstream pull/478/head:fix/order-of-choice-of-formula-for-the-build git checkout fix/order-of-choice-of-formula-for-the-build make build && sudo cp dist/linux/rit /usr/local/bin/- Description for the changelog
Added step to question about formula founded.