-
Notifications
You must be signed in to change notification settings - Fork 102
Added step to question about formula found #478
Added step to question about formula found #478
Conversation
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
01b7b8a
to
84da419
Compare
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=======================================
Coverage 69.03% 69.03%
=======================================
Files 88 88
Lines 2955 2955
=======================================
Hits 2040 2040
Misses 717 717
Partials 198 198 Continue to review full report at Codecov.
|
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…r-of-choice-of-formula-for-the-build Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
…r-of-choice-of-formula-for-the-build Signed-off-by: Bruna Tavares <silvatavares.bruna@gmail.com>
func getFields(fieldsDefault fieldsTestBuildFormulaCmd, fieldsTest fieldsTestBuildFormulaCmd) fieldsTestBuildFormulaCmd { | ||
var fields fieldsTestBuildFormulaCmd = fieldsDefault | ||
|
||
if fieldsTest.directory != nil { | ||
fields.directory = fieldsTest.directory | ||
} | ||
if fieldsTest.inList != nil { | ||
fields.inList = fieldsTest.inList | ||
} | ||
if fieldsTest.localBuilder != nil { | ||
fields.localBuilder = fieldsTest.localBuilder | ||
} | ||
if fieldsTest.workspaceManager != nil { | ||
fields.workspaceManager = fieldsTest.workspaceManager | ||
} | ||
|
||
return fields | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is used to always choose the default fields and if the test defines any field, use the test field.
The d5b81bc commit is the one with just that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge qa |
👌 Merged branch fix/order-of-choice-of-formula-for-the-build into qa |
Qa tests:
|
- What I did
Added a new step in choosing the formula for the build.
When rit finds a directory with a formula, it looks for other formulas in the tree (within the same directory).
If he finds it, he asks the user if he wants to select this formula found or continue searching for another one.
- How to verify it
git fetch upstream pull/478/head:fix/order-of-choice-of-formula-for-the-build git checkout fix/order-of-choice-of-formula-for-the-build make build && sudo cp dist/linux/rit /usr/local/bin/
- Description for the changelog
Added step to question about formula founded.