Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add the 'password' input type to stdin #482

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Add the 'password' input type to stdin #482

merged 1 commit into from
Aug 28, 2020

Conversation

kaduartur
Copy link
Contributor

- What I did

  • Added the 'password' input type to stdin when running formulas

- How to verify it

  • Build this branch and run this command to test:
echo '{"input_text":"Dennis", "input_bool":"false", "input_list":"everything", "input_password":"Ritchie"}' | rit demo hello-world --stdin

- Description for the changelog
Add the 'password' input type to stdin

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
@kaduartur kaduartur added 🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review labels Aug 28, 2020
@kaduartur kaduartur self-assigned this Aug 28, 2020
@kaduartur kaduartur linked an issue Aug 28, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #482 into master will decrease coverage by 4.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   72.48%   67.57%   -4.91%     
==========================================
  Files          97       88       -9     
  Lines        3423     2896     -527     
==========================================
- Hits         2481     1957     -524     
- Misses        728      749      +21     
+ Partials      214      190      -24     
Impacted Files Coverage Δ
pkg/formula/runner/inputs.go 95.38% <100.00%> (-0.77%) ⬇️
pkg/cmd/build_formula.go 0.00% <0.00%> (-52.12%) ⬇️
pkg/cmd/init.go 77.98% <0.00%> (-18.64%) ⬇️
pkg/formula/formula.go 90.90% <0.00%> (-0.52%) ⬇️
pkg/formula/runner/executor.go
pkg/formula/runner/local/pre_run.go
pkg/formula/runner/docker/runner.go
pkg/formula/runner/local/runner.go
pkg/formula/runner.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c27cc7f...5a04150. Read the comment docs.

@lucasdittrichzup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Aug 28, 2020

👌 Merged branch fix/stdin_password into qa

@kaduartur kaduartur added 🚀 QA and removed ✔️ ready-for-review ready for review labels Aug 28, 2020
@kaduartur kaduartur merged commit 17d1a15 into ZupIT:master Aug 28, 2020
@kaduartur kaduartur deleted the fix/stdin_password branch August 28, 2020 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug Report a bug encountered while operating Ritchie
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] STDIN doesn't work with input type PASSWORD
5 participants