-
Notifications
You must be signed in to change notification settings - Fork 102
Add validation with regex in the config.json inputs #512
Add validation with regex in the config.json inputs #512
Conversation
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 98 98
Lines 3287 3287
=======================================
Hits 2641 2641
Misses 462 462
Partials 184 184 Continue to review full report at Codecov.
|
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for your changes. Good job!
pkg/formula/runner/inputs.go
Outdated
if err != nil { | ||
return err | ||
} | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove else
statement and add break
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not understand, because with the break, the for loop will end, is this the correct behavior that you want?
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: JoaoDanielRufino <joaodaniel0405@gmail.com>
Signed-off-by: JoaoDanielRufino joaodaniel0405@gmail.com
- What I did
Added regex type to config.json to check if user input is in accordance with he specified regex in config.json, if not, it will print the mismatchText message and wait for a valid input
- How to verify it
Inside config.json include:
- Description for the changelog
Regex type to config.json