Set tutorial output more informative #583
Conversation
Harirai
force-pushed
the
fix-tutoral-msg
branch
from
6b4073e
to
8fefc9b
Compare
Signed-off-by: Harirai <harim1709@gmail.com>
Harirai
force-pushed
the
fix-tutoral-msg
branch
from
8fefc9b
to
39e7b85
Compare
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 79.89% 79.55% -0.35%
==========================================
Files 98 98
Lines 3253 3218 -35
==========================================
- Hits 2599 2560 -39
- Misses 466 469 +3
- Partials 188 189 +1
Continue to review full report at Codecov.
|
pkg/cmd/tutorial.go
Outdated
| @@ -68,7 +68,7 @@ func (o tutorialCmd) runStdin() CommandRunnerFunc { | |||
| return err | |||
| } | |||
|
|
|||
| prompt.Success("Set tutorial successful!") | |||
| prompt.Success("Set tutorial " + obj.Tutorial + " successful!") | |||
There was a problem hiding this comment.
what you think about
prompt.Success("Tutorial " + response + "d")for me it's a clearer message
There was a problem hiding this comment.
Yeah sure!
I assume you want message to be like "Tutorial enabled" , response already contains "d".
So I think it should be prompt.Success("Tutorial " + response) .
Tell me if I understood it wrong otherwise I'll make the above changes and fix the test soon. 😃
There was a problem hiding this comment.
that's it @Harirai
keep going
|
i see there are functional tests failing ritchie-cli/functional/core/core_feature.json Line 355 in f1b539e |
lucasdittrichzup
added
🔨 improvement
Signed-off-by: Harirai <harim1709@gmail.com>
Signed-off-by: Harirai harim1709@gmail.com
Fixes #525
- What I did
Added user response to
rit tutorialfor more clarity, previously output was "Set tutorial successful" irrespective of user response.Now it shows output corresponding to the input.
Like: "Set tutorial enabled successful".
- How to verify it
By setting tutorial.
- Description for the changelog
Set tutorial output more informative.