-
Notifications
You must be signed in to change notification settings - Fork 102
Remove codecov/project step #629
Remove codecov/project step #629
Conversation
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
- Coverage 81.41% 80.11% -1.31%
==========================================
Files 103 99 -4
Lines 3643 3299 -344
==========================================
- Hits 2966 2643 -323
+ Misses 483 467 -16
+ Partials 194 189 -5
Continue to review full report at Codecov.
|
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES
@@ -180,33 +180,7 @@ func TestPreRun(t *testing.T) { | |||
err: errors.New("error to create dir"), | |||
}, | |||
}, | |||
{ | |||
name: "copy work dir error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this change for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just removing it to test the codecov, i will put it back after finishing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i request reviewers too early, sry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries
=]
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
I like how the explanation is phrased under Description 😃 |
* remove codecov project * ignore vendor Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
* remove codecov project * ignore vendor Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
Description
The codecov/project check is no longer making sense
We need to constantly update the branch because master is always changing
Changelog
Disable codecov/project check