This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Remove codecov/project step #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
- Coverage 81.41% 80.11% -1.31%
==========================================
Files 103 99 -4
Lines 3643 3299 -344
==========================================
- Hits 2966 2643 -323
+ Misses 483 467 -16
+ Partials 194 189 -5
Continue to review full report at Codecov.
|
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
victorschumacherzup
requested review from
brunasilvazup,
henriquemoraeszup,
kaduartur and
lucasdittrichzup
victorschumacherzup
changed the title
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
lucasdittrichzup
previously approved these changes
Oct 22, 2020
brunasilvazup
changed the title
brunasilvazup
added
✔️ ready-for-review
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
henriquemoraeszup
previously approved these changes
Oct 22, 2020
| @@ -180,33 +180,7 @@ func TestPreRun(t *testing.T) { | |||
| err: errors.New("error to create dir"), | |||
| }, | |||
| }, | |||
| { | |||
| name: "copy work dir error", | |||
There was a problem hiding this comment.
what is this change for?
There was a problem hiding this comment.
just removing it to test the codecov, i will put it back after finishing
There was a problem hiding this comment.
i request reviewers too early, sry
Signed-off-by: victor-schumacher <victorschumacher255@gmail.com>
victorschumacherzup
requested review from
henriquemoraeszup and
lucasdittrichzup
henriquemoraeszup
approved these changes
Oct 22, 2020
lucasdittrichzup
approved these changes
Oct 22, 2020
brunasilvazup
approved these changes
Oct 22, 2020
|
I like how the explanation is phrased under Description 😃 |
brunonmelo
pushed a commit
to brunonmelo/ritchie-cli
that referenced
this pull request
Nov 12, 2020
* remove codecov project * ignore vendor Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
brunonmelo
pushed a commit
to brunonmelo/ritchie-cli
that referenced
this pull request
Nov 12, 2020
* remove codecov project * ignore vendor Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The codecov/project check is no longer making sense
We need to constantly update the branch because master is always changing
Changelog
Disable codecov/project check