More linters #631

lcd1232 · 2020-10-23T12:15:19Z

Description

Closes Improves code quality related to linters and tests #510

How to verify it

golangci-lint run ./...

Changelog

codecov-io · 2020-10-23T13:13:30Z

Codecov Report

Merging #631 into master will decrease coverage by 1.54%.
The diff coverage is 72.95%.

@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
- Coverage   81.99%   80.45%   -1.55%     
==========================================
  Files         105      101       -4     
  Lines        3955     3617     -338     
==========================================
- Hits         3243     2910     -333     
+ Misses        513      509       -4     
+ Partials      199      198       -1

Impacted Files	Coverage Δ
pkg/cmd/add.go	`100.00% <ø> (ø)`
pkg/cmd/autocomplete.go	`97.46% <ø> (ø)`
pkg/cmd/cmd.go	`71.42% <ø> (-8.58%)`	⬇️
pkg/cmd/create.go	`100.00% <ø> (ø)`
pkg/cmd/delete.go	`100.00% <ø> (ø)`
pkg/cmd/delete_context.go	`33.33% <ø> (ø)`
pkg/cmd/list.go	`100.00% <ø> (ø)`
pkg/cmd/list_workspace.go	`93.93% <ø> (ø)`
pkg/cmd/set.go	`100.00% <ø> (ø)`
pkg/cmd/set_context.go	`47.22% <ø> (ø)`
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112a782...ed6e5c2. Read the comment docs.

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

# Conflicts: # pkg/commands/builder.go # pkg/formula/runner/inputs.go # pkg/formula/runner/local/runner_test.go

lcd1232 · 2020-10-27T08:22:13Z

@henriquemoraeszup I fixed merged conflicts but I cannot fix DCO. Could you approve it without DCO check?

henriquemoraeszup · 2020-10-28T18:49:40Z

@lcd1232 the dco is passing now =]

henriquemoraeszup · 2020-10-28T18:51:33Z

pkg/cmd/add_repo.go

@@ -177,7 +177,8 @@ func (ad addRepoCmd) runPrompt() CommandRunnerFunc {
 			return err
 		}

-		successMsg := fmt.Sprintf("The %q repository was added with success, now you can use your formulas with the Ritchie!", repository.Name)
+		successMsg := fmt.Sprintf("The %q repository was added with success, "+


What about identing like so

successMsg := fmt.Sprintf( "The %q repository was added with success, now you can use your formulas with the Ritchie!", repository.Name, )

henriquemoraeszup · 2020-10-28T18:52:48Z

pkg/cmd/add_repo.go

+		successMsg := fmt.Sprintf("The %q repository was added with success, "+
+			"now you can use your formulas with the Ritchie!", r.Name)


What about identing like so

Suggested change

successMsg := fmt.Sprintf("The %q repository was added with success, "+

"now you can use your formulas with the Ritchie!", r.Name)

successMsg := fmt.Sprintf(

"The %q repository was added with success, now you can use your formulas with Ritchie!",

r.Name,

)

henriquemoraeszup · 2020-10-28T18:55:03Z

pkg/cmd/autocomplete.go

@@ -34,12 +34,12 @@ const (

 var supportedShell = []string{zsh.String(), bash.String(), fish.String(), powerShell.String()}

-// autocompleteCmd type for set autocomplete command
+// autocompleteCmd type for set autocomplete command.


How important is this rule to keep it? I feel this could become an experience barrier for users from the community making PRs to Ritchie to have to add periods in comments

I tried to add this linter, but then I realized that I don't have enough patience to do this. Right now it's disabled. I can discard this change if you want.

no, it is fine this way

henriquemoraeszup · 2020-10-28T18:56:13Z

pkg/cmd/metrics.go

@@ -35,7 +35,9 @@ func NewMetricsCmd(file stream.FileWriteReadExister, inList prompt.InputList) *c
 func (m metricsCmd) run() CommandRunnerFunc {
 	return func(cmd *cobra.Command, args []string) error {
 		options := []string{"yes", "no"}
-		choose, err := m.input.List("You want to send anonymous data about the product, feature use, statistics and crash reports?", options)
+		choose, err := m.input.List("You want to send anonymous data "+


How about newlining on the parenthesis?

choose, err := m.input.List( ... )

henriquemoraeszup · 2020-10-28T18:56:59Z

pkg/formula/runner/docker/pre_run.go

+	ErrDockerNotInstalled = errors.New("you must have the docker installed to run formulas inside it," +
+		" check how to install it at: [https://docs.docker.com/get-docker]")
+	ErrDockerImageNotFound = errors.New("config.json does not contain the" +
+		" \"dockerImageBuilder\" field, to run this formula with docker add a docker image name to it")
+	ErrDockerfileNotFound = errors.New("the formula cannot be executed inside the docker," +
+		" you must add a \"Dockerfile\" to execute the formula inside the docker")


How about newlining on the parenthesis?

henriquemoraeszup · 2020-10-28T18:57:58Z

pkg/upgrade/url_finder.go

 	return DefaultUrlFinder{version: version}
 }

-func (duf DefaultUrlFinder) Url(os string) string {
+func (duf DefaultUrlFinder) Url(os string) string { //nolint:stylecheck
 	//stableVersion, err := resolver.StableVersion()


can we remove this commented code?

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

# Conflicts: # pkg/cmd/formula.go # pkg/formula/input/prompt/prompt.go # pkg/formula/runner/local/runner_test.go

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

henriquemoraeszup

Nice job! Thanks for the contribution!

brunasilvazup · 2020-10-30T18:07:03Z

pkg/metric/http_sender.go

+	resp, err := sm.client.Do(req)
+	if err != nil {
+		return
+	}


Do you can use _ in this err? and dont check if.

brunasilvazup · 2020-11-06T17:02:03Z

/merge qa

ritchie-bot · 2020-11-06T17:03:09Z

🔥 Merge Conflict

victorschumacherzup · 2020-11-06T19:31:54Z

/merge qa

ritchie-bot · 2020-11-06T19:31:58Z

👌 Merged branch add_linters into qa

* Add file Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Remove one of linters Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Update ci Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More disables Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Disable one linter, fix code Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More improvements Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix errors Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More improvements Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Update ci Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Improve linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix linter Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * goftm Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * More fixes Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix some gocritic issues Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversation * Improvement pipeline (ZupIT#614) * adding stg environment * adding stg environment Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * Trying to make DCO pass Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * adding stg environment (ZupIT#606) * adding stg environment * adding stg environment Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * Trying to make DCO pass Signed-off-by: Vinicius Ramos de Faria <viniciusramosdefaria@gmail.com> * refactoring pipeline * minor tweaks * removing unnecessary files * adding routing script Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * added context printing (ZupIT#632) * added context printing Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * fix extra spaces, showling only non default contexts now Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Prompt to auto rebuild formula on source modifications (ZupIT#578) * Prompting to rebuild on modifications Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Go style to pre run builder Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Running pre build for local repo only Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding more pre run build tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Refactor: Extracting workspace hashing to workspace.go Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Updating formula hash on manual builds Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Adding workspace hash tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Customizing workspace hashing custom mock methods Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Organizing pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Removing dead code Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * refactor: Organizing pre run builder tests Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Hashing the whole formula instead of only the src Signed-off-by: Gabriel Pinheiro <gabrielctpinheiro@gmail.com> * Decoupling build commands from main (ZupIT#630) * Decoupling build commands from main Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> * Linter Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * added warning on same env name (ZupIT#633) * added warning and test case Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * remove print' Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> * new function for check Signed-off-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Merge master Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Disable maligned Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix ci * Check for errors * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Resolve conversations Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> * Fix errors after merge Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com> Co-authored-by: viniciusramosdefaria <viniciusramosdefaria@gmail.com> Co-authored-by: Victor Schumacher <51962831+victorschumacherzup@users.noreply.github.com> Co-authored-by: victor-schumacher <victorschumacher255@gmail.com> Co-authored-by: gabriel-pinheiro <56726395+gabriel-pinheiro@users.noreply.github.com> Co-authored-by: henriquemoraeszup <68074718+henriquemoraeszup@users.noreply.github.com> Signed-off-by: Bruno N. Melo <brunonobrega.melo@gmail.com>

GuillaumeFalourd requested a review from brunasilvazup October 23, 2020 12:26

GuillaumeFalourd assigned lcd1232 Oct 23, 2020

GuillaumeFalourd added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 23, 2020

lcd1232 added 26 commits October 23, 2020 16:15

Add file

561eb1f

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Remove one of linters

fe25f03

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Update ci

1c1b949

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More disables

97b74b5

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Fix linter

93dbc38

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Fix linter

df1a6f8

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Disable one linter, fix code

d3f2b88

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More improvements

86b8199

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Fix errors

78bc162

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More improvements

7e9ac73

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Update ci

5933643

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

ef0e336

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

7be6681

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

96ce089

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

2445f2f

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

3cda12a

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

5b4b9e5

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

2147083

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

929c6a3

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

42cc972

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

d55e33f

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

738ed6e

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Improve linter

7a73db7

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

f2f0280

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

fb43594

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

More fixes

973fdbf

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

lcd1232 added 3 commits October 27, 2020 11:18

Merge remote-tracking branch 'original/master' into add_linters

13009c8

# Conflicts: # pkg/commands/builder.go # pkg/formula/runner/inputs.go # pkg/formula/runner/local/runner_test.go

Fix ci

72d80ac

Check for errors

ac340d9

brunasilvazup added ✔️ ready-for-review ready for review and removed waiting reply Waiting for an answer to a comment labels Oct 27, 2020

brunasilvazup requested review from henriquemoraeszup and brunasilvazup October 27, 2020 16:30

henriquemoraeszup reviewed Oct 28, 2020

View reviewed changes

lcd1232 requested review from kaduartur, lucasdittrichzup, rodrigomedeirosf and victorschumacherzup as code owners October 29, 2020 17:29

lcd1232 added 5 commits October 29, 2020 20:34

Resolve conversations

6b719f2

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Resolve conversations

a1825ae

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Resolve conversations

ed6e5c2

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

Merge remote-tracking branch 'original/master' into add_linters

c472bfa

# Conflicts: # pkg/cmd/formula.go # pkg/formula/input/prompt/prompt.go # pkg/formula/runner/local/runner_test.go

Fix errors after merge

76145ff

Signed-off-by: lcd1232 <8745863+lcd1232@users.noreply.github.com>

henriquemoraeszup approved these changes Oct 30, 2020

View reviewed changes

brunasilvazup reviewed Oct 30, 2020

View reviewed changes

ZupIT deleted a comment from ritchie-bot bot Nov 6, 2020

henriquemoraeszup merged commit 970b8ec into ZupIT:master Nov 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More linters #631

More linters #631

lcd1232 commented Oct 23, 2020 •

edited

Loading

codecov-io commented Oct 23, 2020 •

edited

Loading

lcd1232 commented Oct 27, 2020

henriquemoraeszup commented Oct 28, 2020

henriquemoraeszup Oct 28, 2020

lcd1232 Oct 29, 2020

henriquemoraeszup Oct 28, 2020

lcd1232 Oct 29, 2020

henriquemoraeszup Oct 28, 2020

lcd1232 Oct 29, 2020

henriquemoraeszup Oct 30, 2020

henriquemoraeszup Oct 28, 2020

lcd1232 Oct 29, 2020

henriquemoraeszup Oct 28, 2020

lcd1232 Oct 29, 2020

henriquemoraeszup Oct 28, 2020

lcd1232 Oct 29, 2020

henriquemoraeszup left a comment

brunasilvazup Oct 30, 2020

brunasilvazup commented Nov 6, 2020

ritchie-bot bot commented Nov 6, 2020

victorschumacherzup commented Nov 6, 2020

ritchie-bot bot commented Nov 6, 2020

		successMsg := fmt.Sprintf("The %q repository was added with success, "+
		"now you can use your formulas with the Ritchie!", r.Name)

More linters #631

More linters #631

Conversation

lcd1232 commented Oct 23, 2020 • edited Loading

Description

How to verify it

Changelog

codecov-io commented Oct 23, 2020 • edited Loading

Codecov Report

lcd1232 commented Oct 27, 2020

henriquemoraeszup commented Oct 28, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henriquemoraeszup left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brunasilvazup commented Nov 6, 2020

ritchie-bot bot commented Nov 6, 2020

victorschumacherzup commented Nov 6, 2020

ritchie-bot bot commented Nov 6, 2020

lcd1232 commented Oct 23, 2020 •

edited

Loading

codecov-io commented Oct 23, 2020 •

edited

Loading