This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
Tests on credential pkg #806
Merged
kaduartur
merged 11 commits into
ZupIT:master
from
henriquemoraeszup:hm/tests-on-credential-pkg
Dec 23, 2020
Merged
Tests on credential pkg #806
kaduartur
merged 11 commits into
ZupIT:master
from
henriquemoraeszup:hm/tests-on-credential-pkg
Dec 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
henriquemoraeszup
requested review from
brunasilvazup,
kaduartur,
lucasdittrichzup,
rodrigomedeirosf and
victorschumacherzup
as code owners
December 18, 2020 18:46
5 tasks
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
==========================================
- Coverage 82.52% 82.40% -0.12%
==========================================
Files 110 109 -1
Lines 3806 3803 -3
==========================================
- Hits 3141 3134 -7
- Misses 481 483 +2
- Partials 184 186 +2
Continue to review full report at Codecov.
|
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
…n-credential-pkg merge
5 tasks
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
5 tasks
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
kaduartur
approved these changes
Dec 21, 2020
brunasilvazup
approved these changes
Dec 22, 2020
/merge qa |
👌 Merged branch hm/tests-on-credential-pkg into qa |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor to add testify, remove mocks, and take out dependencies of the
credentials
packageHow to verify it
Run tests
Changelog
Code refactor of the credentials package