Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Tests on credential pkg #806

Merged
merged 11 commits into from
Dec 23, 2020

Conversation

henriquemoraeszup
Copy link
Contributor

Description

Refactor to add testify, remove mocks, and take out dependencies of the credentials package

How to verify it

Run tests

Changelog

Code refactor of the credentials package

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@codecov-io
Copy link

codecov-io commented Dec 18, 2020

Codecov Report

Merging #806 (78c7d2d) into master (13b1f44) will decrease coverage by 0.11%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
- Coverage   82.52%   82.40%   -0.12%     
==========================================
  Files         110      109       -1     
  Lines        3806     3803       -3     
==========================================
- Hits         3141     3134       -7     
- Misses        481      483       +2     
- Partials      184      186       +2     
Impacted Files Coverage Δ
pkg/credential/credential.go 0.00% <ø> (ø)
pkg/credential/setter.go 60.00% <66.66%> (-1.91%) ⬇️
pkg/commands/builder.go 90.20% <100.00%> (ø)
pkg/credential/delete.go 83.33% <100.00%> (-16.67%) ⬇️
pkg/credential/finder.go 76.47% <100.00%> (ø)
pkg/credential/resolver.go 90.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b1f44...78c7d2d. Read the comment docs.

Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup henriquemoraeszup linked an issue Dec 19, 2020 that may be closed by this pull request
5 tasks
Signed-off-by: Henrique Moraes <henrique.moraes@zup.com.br>
@henriquemoraeszup henriquemoraeszup self-assigned this Dec 19, 2020
@kaduartur
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Dec 22, 2020

👌 Merged branch hm/tests-on-credential-pkg into qa

@kaduartur kaduartur merged commit 10cd781 into ZupIT:master Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests with Testify in Pkg/Credential
4 participants