Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

feat: add bitbucket as a provider to add repos #823

Merged
merged 15 commits into from
Jan 22, 2021
Merged

feat: add bitbucket as a provider to add repos #823

merged 15 commits into from
Jan 22, 2021

Conversation

lucasdittrichzup
Copy link
Contributor

Description

This PR adds Bitbucket as a provider to add repos.

gif containing the command demonstration

Close #647

How to verify it

  • Add new repo with rit add repo
  • Run the unit tests with make unit-test command

Changelog

Add Bitbucket provider to add repos

@lucasdittrichzup
feat: add bitbucket as a provider to add repos
5956ecc 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup lucasdittrichzup added 📚 documentation Improvements or additions to documentation ✨ feature Suggest a new feature or enhancement to the Ritchie project ✔️ ready-for-review ready for review labels Jan 8, 2021
@lucasdittrichzup lucasdittrichzup self-assigned this Jan 8, 2021
@lucasdittrichzup
fix: remove unused type in repository.go (bitbucket)
47af2ec 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@codecov-io
Copy link

codecov-io commented Jan 8, 2021 •
edited
Loading

Codecov Report

Merging #823 (f532c1f) into master (d485675) will increase coverage by 0.03%.
The diff coverage is 86.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
+ Coverage   84.34%   84.37%   +0.03%     
==========================================
  Files         111      113       +2     
  Lines        3857     3930      +73     
==========================================
+ Hits         3253     3316      +63     
- Misses        432      437       +5     
- Partials      172      177       +5
Impacted Files Coverage Δ
pkg/git/bitbucket/repository.go 81.81% <81.81%> (ø)
pkg/commands/builder.go 90.40% <100.00%> (+0.09%) ⬆️
pkg/git/bitbucket/bitbucket.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d485675...f532c1f. Read the comment docs.

henriquemoraeszup
henriquemoraeszup reviewed Jan 11, 2021
View reviewed changes
pkg/git/bitbucket/bitbucket.go Show resolved Hide resolved
pkg/git/bitbucket/bitbucket.go Outdated Show resolved Hide resolved
pkg/git/bitbucket/bitbucket.go Outdated Show resolved Hide resolved
pkg/git/bitbucket/bitbucket_test.go Outdated Show resolved Hide resolved
pkg/git/bitbucket/bitbucket_test.go Show resolved Hide resolved
pkg/git/bitbucket/repository_test.go Outdated Show resolved Hide resolved
pkg/git/bitbucket/repository_test.go Outdated Show resolved Hide resolved
pkg/git/bitbucket/repository_test.go Outdated Show resolved Hide resolved
pkg/git/bitbucket/repository_test.go Show resolved Hide resolved
pkg/git/bitbucket/repository_test.go Outdated Show resolved Hide resolved
brunasilvazup
brunasilvazup previously approved these changes Jan 11, 2021
View reviewed changes
@lucasdittrichzup
test: add mocks for bitbucket testing
a4aeafc 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
test: add and refact bitbucket tests
6752b36 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
fix: fix review
85b52d4 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@brunasilvazup brunasilvazup added 🚧 WIP Work in Progress waiting reply Waiting for an answer to a comment and removed ✔️ ready-for-review ready for review labels Jan 19, 2021
brunasilvazup
brunasilvazup reviewed Jan 19, 2021
View reviewed changes
Copy link
Contributor

@brunasilvazup brunasilvazup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some other comments, see what you think.

@brunasilvazup brunasilvazup removed the 🚧 WIP Work in Progress label Jan 19, 2021
@ZupIT ZupIT deleted a comment from brunasilvazup Jan 19, 2021
@lucasdittrichzup
fix: fix review
1621cfd 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
feat: add bitbucket as a provider to add repos
70c9e75 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
fix: remove unused type in repository.go (bitbucket)
ae8a431 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
test: add mocks for bitbucket testing
45506ae 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
test: add and refact bitbucket tests
962f5ab 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
fix: fix review
9957b94 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
fix: fix review
5b902c0 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup
Merge branch 'feature/add-bitbucket-provider' of github.com:lucasditt…
7be98a3 
…richzup/ritchie-cli into feature/add-bitbucket-provider
@lucasdittrichzup lucasdittrichzup added ✔️ ready-for-review ready for review and removed waiting reply Waiting for an answer to a comment labels Jan 19, 2021
brunasilvazup
brunasilvazup previously approved these changes Jan 21, 2021
View reviewed changes
@brunasilvazup brunasilvazup linked an issue Jan 21, 2021 that may be closed by this pull request
Support flags for rit add repo #711
Closed
@brunasilvazup brunasilvazup removed a link to an issue Jan 21, 2021
Support flags for rit add repo #711
Closed
henriquemoraeszup
henriquemoraeszup reviewed Jan 21, 2021
View reviewed changes
Copy link
Contributor

@henriquemoraeszup henriquemoraeszup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests, 👏
Just a couple of comments

internal/mocks/mocks.go Outdated Show resolved Hide resolved
pkg/git/bitbucket/repository.go Outdated Show resolved Hide resolved
@henriquemoraeszup henriquemoraeszup added waiting reply Waiting for an answer to a comment and removed ✔️ ready-for-review ready for review labels Jan 21, 2021
@lucasdittrichzup
refactor: remove duplicate code and separate mock in another file
a4c6394 
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup lucasdittrichzup added ✔️ ready-for-review ready for review and removed waiting reply Waiting for an answer to a comment labels Jan 21, 2021
@lucasdittrichzup lucasdittrichzup merged commit e733679 into ZupIT:master Jan 22, 2021
@lucasdittrichzup lucasdittrichzup deleted the feature/add-bitbucket-provider branch July 21, 2021 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brunasilvazup brunasilvazup brunasilvazup approved these changes

@henriquemoraeszup henriquemoraeszup henriquemoraeszup approved these changes

@kaduartur kaduartur Awaiting requested review from kaduartur

@rodrigomedeirosf rodrigomedeirosf Awaiting requested review from rodrigomedeirosf

Assignees

@lucasdittrichzup lucasdittrichzup

Labels
📚 documentation Improvements or additions to documentation ✔️ ready-for-review ready for review ✨ feature Suggest a new feature or enhancement to the Ritchie project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Bitbucket to provider list for rit add repo
4 participants
@lucasdittrichzup @codecov-io @brunasilvazup @henriquemoraeszup