This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
fix: required multiselect #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
lucasdittrichzup
added
🪲 bug
lucasdittrichzup
requested review from
brunasilvazup,
henriquemoraeszup,
kaduartur and
rodrigomedeirosf
as code owners
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 113 113
Lines 4011 4011
=======================================
Hits 3383 3383
Misses 442 442
Partials 186 186 Continue to review full report at Codecov.
|
henriquemoraeszup
previously approved these changes
Jan 29, 2021
brunasilvazup
previously approved these changes
Jan 29, 2021
kaduartur
suggested changes
Feb 1, 2021
brunasilvazup
added
🕒 Wait
waiting reply
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
lucasdittrichzup
dismissed stale reviews from brunasilvazup and henriquemoraeszup
via
a32e051
lucasdittrichzup
requested review from
henriquemoraeszup,
kaduartur and
brunasilvazup
lucasdittrichzup
added
✔️ ready-for-review
brunasilvazup
approved these changes
Feb 4, 2021
kaduartur
approved these changes
Feb 5, 2021
henriquemoraeszup
approved these changes
Feb 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The adoption team found a bug in the multiselect input when the required field is not sent.
To solve this, a validation was added that checks if the field is sent before being used in the code.
Close #839
How to verify it
git fetch origin pull / 842 / head: fix/required-multiselect)Changelog
Add validation in case the required field is not sent in the multiselect input