-
Notifications
You must be signed in to change notification settings - Fork 102
refactor: deprecated dynamic input #848
refactor: deprecated dynamic input #848
Conversation
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
if (tt.want != nil && got == nil) || got != nil && got.Error() != tt.want.Error() { | ||
t.Errorf("PostRun(%s) got %v, want %v", tt.name, got, tt.want) | ||
} | ||
assert.Equal(t, tt.want, got) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, right 🌟
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
==========================================
+ Coverage 84.34% 84.35% +0.01%
==========================================
Files 113 113
Lines 4011 4015 +4
==========================================
+ Hits 3383 3387 +4
Misses 442 442
Partials 186 186
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, we cannot consider yet this to be the test refactor. We would still have to remove the filemanagermock
and test for the file system side effects
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
…ttrichzup/ritchie-cli into feature/deprecated-dynamic-input
58d43a4
Description
In the coming months, due to the formula output feature, the type of dynamic input will be depreciated.
Because of this, this PR adds a warning for users who use this type of input in their formulas, as shown in the GIF below:
Close #813
How to verify it
git fetch origin pull / 848 / head: feature/deprecated-dynamic-input
)Changelog
Adds depreciation warning of dynamic input