This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
refactor: deprecated dynamic input #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
lucasdittrichzup
added
📚 documentation
lucasdittrichzup
requested review from
brunasilvazup,
henriquemoraeszup,
kaduartur and
rodrigomedeirosf
as code owners
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
| if (tt.want != nil && got == nil) || got != nil && got.Error() != tt.want.Error() { | ||
| t.Errorf("PostRun(%s) got %v, want %v", tt.name, got, tt.want) | ||
| } | ||
| assert.Equal(t, tt.want, got) |
brunasilvazup
added
waiting reply
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
lucasdittrichzup
added
✔️ ready-for-review
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
==========================================
+ Coverage 84.34% 84.35% +0.01%
==========================================
Files 113 113
Lines 4011 4015 +4
==========================================
+ Hits 3383 3387 +4
Misses 442 442
Partials 186 186
Continue to review full report at Codecov.
|
henriquemoraeszup
previously approved these changes
Feb 5, 2021
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
…ttrichzup/ritchie-cli into feature/deprecated-dynamic-input
lucasdittrichzup
dismissed stale reviews from henriquemoraeszup and brunasilvazup
via
58d43a4
brunasilvazup
approved these changes
Feb 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the coming months, due to the formula output feature, the type of dynamic input will be depreciated.
Because of this, this PR adds a warning for users who use this type of input in their formulas, as shown in the GIF below:
Close #813
How to verify it
git fetch origin pull / 848 / head: feature/deprecated-dynamic-input)Changelog
Adds depreciation warning of dynamic input