On the web, modify the current URL as we change maps and scenarios. #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
reviewed
Feb 12, 2021
| // Setting window.location.href may seem like the obvious thing to do, but that actually | ||
| // refreshes the page. This method just changes the URL and doesn't mess up history. See | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/History_API/Working_with_the_History_API. | ||
| let history = window.history().map_err(|err| { |
There was a problem hiding this comment.
TIL that web-sys Results have a JSValue as their Err case.
Some discussion to change that:
rustwasm/wasm-bindgen#1742
But seems like it's stalled out.
There was a problem hiding this comment.
Ah, it would be so nice if this went through. In the meantime, I guess we can keep the boilerplate. And maybe figure out a macro/helper to make it a bit more ergonomic.
michaelkirk
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the web experience slightly nicer, letting somebody copy the URL and send it to a friend, and have them at least wind up on the right map or scenario. It doesn't work in general for jumping to a challenge mode or tutorial or arbitrary game state, but I think that's likely overkill -- this covers the common cases.
The simplest test: run locally, open localhost without any query params to get the title screen. Clicking sandbox brings you to the montlake scenario, and now your address bar should reflect this:
