-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
I wonder if following this template is overkill. New dependencies on Travis and Appveyor build systems? We don't need full automation for publishing to NPM every time we commit here; we don't want that even! To start, if we manually run a few commands to publish, that'd almost be preferable. Also not sure we need a new crate to expose a JS interface. In another project, I just tacked on the tiny WASM interface at the end: https://github.com/zonebuilders/zonebuilder-rust/blob/a3070b9332227f9ebc074c6879448d050ea99887/src/lib.rs#L272 I may have some time this weekend to play around with all of this. I'm fine moving forward with something working, but I would like to eventually go back and simplify it |
Oh, I need to cleanup the template (draft). I wuold expect a simple Github Actions based deployment...
Agreed, but I don't want to bring any WASM stuff into the default osm2lanes crate. |
The feature flags should be pretty simple: https://github.com/zonebuilders/zonebuilder-rust/blob/a3070b9332227f9ebc074c6879448d050ea99887/Cargo.toml#L21 So ideally all we need to do is add that to |
I ran into some problems where target + crate-type + features could not be configured correctly to do the right thing. See open issues like: rust-lang/cargo#1197 I am leaning back again to making this a separate crate :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like what I'd expect to need. I should just run things myself and see, but I don't understand what the problem is with tying everything to --features=wasm
. But a separate crate also is fine if that's needed
|
||
[features] | ||
default = ["console_error_panic_hook"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, why's this in default? Related to trying to make features per compilation target work?
In response to 3DStreet/3dstreet#138 (comment)