Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't generate a type attribute for <script> elements, update associated docs #1053

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

therealparmesh
Copy link
Contributor

@therealparmesh therealparmesh commented Jan 22, 2025

From the MDN docs about the script element:

Attribute is not set (default), an empty string, or a JavaScript MIME type

Indicates that the script is a "classic script", containing JavaScript code. Authors are encouraged to omit the attribute if the script refers to JavaScript code rather than specify a MIME type. JavaScript MIME types are listed in the IANA media types specification.

I think it'd be good to reflect the best practices for <script> tag usage in templ docs.

Thank you for this library, and keep up the great work!

Copy link
Owner

@a-h a-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot.

@a-h a-h changed the title chore(docs): update <script> type refactor: don't generate a type attribute for <script> elements, update associated docs Jan 22, 2025
@a-h a-h merged commit 2514d89 into a-h:main Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants