Support mirroring ptex, scie-jump and provided dists. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
force-pushed
the
issues/114
branch
4 times, most recently
from
95fd0a2 to
65c3a57
Compare
jsirois
commented
Jan 12, 2025
Introduce a `science download` family of commands for mirroring a-scie binaries and provider distributions to a local directory tree that can be served up or used directly via `file://` URLs in new `base_url` configuration options for the corresponding lift manifest entries. Fixes a-scie#114
jsirois
changed the title
|
@ubmarco if you have time to take a look / provide feedback, I'd be grateful. Even if the PR is submitted I'll be happy to address further refinement of your use case. |
|
Reviewers: pretty huge - I don't expect a review - this is FYI that science will shortly support fully offline / corporate fire-walled use in a reasonably convenient way. |
jsirois
commented
Jan 13, 2025
| fetches_present = any( | ||
| isinstance(file.source, Fetch) and file.source.lazy for file in requested_files | ||
| ) | ||
| if application.ptex or fetches_present: |
There was a problem hiding this comment.
It turns out application.ptex is always non-null and so this change caused a ptex binary to be included in every scie, needed or not.
jsirois
added a commit
that referenced
this pull request
Jan 13, 2025
Only include it when needed. The over-eager inclusion originated here in the 0.11.0 release: #120 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
science downloadfamily of commands for mirroring a-sciebinaries and provider distributions to a local directory tree that can
be served up or used directly via
file://URLs in newbase_urlconfiguration options for the corresponding lift manifest entries.
Fixes #113
Fixes #114