Fix installer.sh to only require /bin/sh.
#141
Merged
+283
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is especially relevant post https://github.com/a-scie/lift/releases/tag/v0.12.0. |
jsirois
changed the title
/bin/sh.installer.sh to only require /bin/sh.
jsirois
commented
Feb 17, 2025
| run: | | ||
| cat << EOF > _test.sh |
There was a problem hiding this comment.
All this yaml-thrash and the paired intro of scripts/docker/uv.py was just so I could test the install.sh changes locally via uvrc docker -- --image alpine test -- -vvsk test_installer (where uvrc is my alias for uv run dev-cmd). The upshot of streamlined yaml / an easy way to repro CI locally is, of course, generally good.
jsirois
added a commit
that referenced
this pull request
Feb 18, 2025
Also improve docker dev-cmd to support `--inspect` and cache image builds. A follow-up to #141 which left install.sh working, but with ugly output that rendered escape codes instead of colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables use on alpine linux and busybox images.
Fixes #139