Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fixed response data as JSON #140

Merged
merged 7 commits into from
Jun 23, 2022
Merged

🐛 fixed response data as JSON #140

merged 7 commits into from
Jun 23, 2022

Conversation

dauden
Copy link
Contributor

@dauden dauden commented Jun 23, 2022

Description:

  • populate response data as JSON if not empty
  • add test cases for each function

@dauden dauden requested a review from a-tokyo as a code owner June 23, 2022 10:51
@dauden
Copy link
Contributor Author

dauden commented Jun 23, 2022

@a-tokyo
sorry for my mistake! empty string or null from buffer can not parse to JSON.
I have fixed and added some test cases for each function.

Thanks

@a-tokyo
Copy link
Owner

a-tokyo commented Jun 23, 2022

@dauden All good! No worries, we all do some kind of mistake every now and then! That's why the tests are there.

@a-tokyo a-tokyo changed the title [138] fixed response data as JSON 🐛 fixed response data as JSON Jun 23, 2022
@a-tokyo a-tokyo merged commit 95f75bf into a-tokyo:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-tokyo a-tokyo a-tokyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dauden @a-tokyo