Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript Declarations for Enhanced Type Safety #78

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

Erickinhou
Copy link
Contributor

Description:

This pull request introduces TypeScript declaration files (*.d.ts) to enhance the type safety of the 'react-apple-signin-auth' repository. By providing accurate type information, developers can benefit from improved code autocompletion, better documentation, and early detection of potential type-related errors during development.

  • Added TypeScript declaration files for existing and new components, ensuring comprehensive type coverage.
  • Added the project's tsconfig.json to include the newly added declaration files.
  • Verified that the TypeScript compiler successfully processes the code with the new declaration files.

Additional Notes:

I wanted to know if this will work, I'm doing this because I almost used it in a company, but the fact that it doesn't have types makes it impossible to use.

Please review and provide feedback on the changes. Your input is valuable to ensure the successful integration of TypeScript into the project.

@tony95271
Copy link

@a-tokyo request for review

@tony95271 tony95271 mentioned this pull request Nov 14, 2023
Copy link
Owner

@a-tokyo a-tokyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Please bump the minor version number

@Erickinhou
Copy link
Contributor Author

Awesome work!

Please bump the minor version number

Done!

@a-tokyo a-tokyo merged commit 39f9d19 into a-tokyo:main Nov 16, 2023
2 checks passed
@Thenodai Thenodai mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants