-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toml config, take 2 #298
Merged
Merged
toml config, take 2 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
different take on #125 |
daejunpark
reviewed
May 30, 2024
libs: Dict, | ||
) -> Exec: | ||
setup_timer = NamedTimer("setup") | ||
setup_timer.create_subtimer("decode") | ||
|
||
sevm = SEVM(mk_options(args)) | ||
sevm = SEVM(args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
daejunpark
approved these changes
May 31, 2024
daejunpark
reviewed
May 31, 2024
I'll add a full halmos.toml example in a follow up |
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Jun 2, 2024
### 🕓 Changelog The PRs a16z/halmos#296 and a16z/halmos#298 have added support for configuration files in `halmos` (https://github.com/a16z/halmos). This PR refactors the configurations currently used inline via the CLI and moves them to the new configuration file `halmos.toml`, which is located in the `test/` subdirectory. I also rename the configuration file `echidna-config.yaml` to `echidna.yaml` and move it to the subdirectory `test/` as well. Eventually, I bump the submodules `FreshCryptoLib` (https://github.com/rdubois-crypto/FreshCryptoLib) and `properties` (https://github.com/crytic/properties) to the latest available commit. --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New design principles
Advantages: