-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/batched grand products #481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and sparse_interleaved_poly)
moodlezoup
force-pushed
the
feat/batched-grand-products
branch
from
October 28, 2024 20:13
9d73567
to
c406f83
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
moodlezoup
force-pushed
the
feat/batched-grand-products
branch
from
November 4, 2024 21:48
edb3a54
to
cdedfd3
Compare
moodlezoup
force-pushed
the
feat/batched-grand-products
branch
from
November 7, 2024 22:37
854c0ab
to
2cf107a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we batch grand products to reduce proof size and verifier cost.
Previously, a batch of k grand products, each of size n, would be batched via random linear combination into a single grand product of size n. With this batching approach, the grand product proof contains 2*k claimed polynomial evaluations per layer.
With this PR, a batch of k grand products, each of size n, would be proven as a single circuit: this can be viewed as simply laying out the individual grand product circuits side-by-side, so that the output layer is of size k. With this new approach, the grand product proof contains only 2 claims per layer.
In addition, this PR implements the Dao-Thaler optimization for EQ polynomials: https://eprint.iacr.org/2024/1210.pdf