Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions to test and build binaries for x86_64/arm64 #33

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

apenney
Copy link
Contributor

@apenney apenney commented Nov 20, 2021

Hi!

We really need to build this binary for arm64 (we're switching to m1 macs) and I figured it wouldn't be fair to ask you to put any work in so I whipped this up. This PR:

  • Tests on Go 1.16/1.17 in github actions
  • Automatically builds linux/darwin x86_64/arm64 binaries whenever you cut a release

I'd love it if you'd merge this and cut a release :)

@apenney apenney force-pushed the add-github-actions-to-build-test branch from 3634450 to 58b19c1 Compare November 20, 2021 23:49
@a8m
Copy link
Owner

a8m commented Nov 22, 2021

Thanks a lot for the contribution @apenney, and sorry for the delay. I'm too busy with other OSS projects lately.

@a8m a8m merged commit d500bc2 into a8m:master Nov 22, 2021
@a8m
Copy link
Owner

a8m commented Nov 22, 2021

@apenney
Copy link
Contributor Author

apenney commented Nov 22, 2021

Weird, I think go.dev was just acting up, https://go.dev/VERSION?m=text was failing - I think another run will magically fix it :(

@apenney apenney deleted the add-github-actions-to-build-test branch November 23, 2021 04:01
@a8m
Copy link
Owner

a8m commented Nov 23, 2021

Still failing :|

a8m added a commit that referenced this pull request Nov 23, 2021
@a8m
Copy link
Owner

a8m commented Nov 23, 2021

OK, I reverted it for now and uploaded binaries for Linux and Mac (arm64). Please, if you have time to debug and resubmit this PR (maybe check it on your repository), it will be great. Thanks!

apenney pushed a commit to apenney/envsubst that referenced this pull request Nov 23, 2021
a8m pushed a commit that referenced this pull request Jun 28, 2022
* Revert "Revert "Add testing action (#33)""

This reverts commit a902c9c.

* Upgrade action to fix redirect issue

* Rename workflow

Co-authored-by: Ashley Penney <ashley@releasehub.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants