Allow default value expression starting with operators #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a8m thanks for merging! Do you have any plans to release this fix soon? My actual goal is to get it fixed in |
go get github.com/a8m/envsubst@masterBut I'll tag master anyway. Thanks again for the contribution. |
a8m
pushed a commit
that referenced
this pull request
Feb 8, 2023
Hfd88
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
I hope that I got the lexing right and I think (according to the added test cases) that it actually fixes the issue without introducing new bugs. The trick was to only lex the any subsitition operator first and then continue with anything after the subsitution (such as constant text or another variable, which may in turn contain a substitution I suppose).