Drop dependency on time
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbr currently depends on version 0.1 of time which is was found to contain a security vulnerability (RUSTSEC-2020-0071 [1]). Updating to the current 0.3 branch would be a possiblity, however that doesn't gain us anything over just relying on std. SteadyTime no longer exists and was never actually steady in the first place [2]. For a while there was a fallback that turned SteadyTime into an alias for time::Instant [3] which in turn is a wrapper around std::time::Instant adding support for negative durations. pbr doesn't deal with negative durations so swap time::Duration for std::time::Duration and time::SteadyTime for std::time::Instant. [1] https://rustsec.org/advisories/RUSTSEC-2020-0071 [2] time-rs/time#95 [3] time-rs/time@76e3575
|
Thanks for the contribution @LingMan. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pbr currently depends on version 0.1 of time which is was found to contain a security vulnerability
(RUSTSEC-2020-0071 [1]). Updating to the current 0.3 branch would be a possiblity, however that
doesn't gain us anything over just relying on std. SteadyTime no longer exists and was never
actually steady in the first place [2]. For a while there was a fallback that turned SteadyTime
into an alias for time::Instant [3] which in turn is a wrapper around std::time::Instant adding
support for negative durations.
pbr doesn't deal with negative durations so swap time::Duration for std::time::Duration and
time::SteadyTime for std::time::Instant.
[1] https://rustsec.org/advisories/RUSTSEC-2020-0071
[2] time-rs/time#95
[3] time-rs/time@76e3575