Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building on Windows #116

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Fix building on Windows #116

merged 1 commit into from
Feb 8, 2023

Conversation

AlyoshaVasilieva
Copy link
Contributor

Building on Windows was broken by 5ee1f9c (I think); extern crate statements were removed, but uses were only adjusted for unix, not Windows

@a8m
Copy link
Owner

a8m commented Feb 8, 2023

@LingMan, can you please help review this?

@LingMan LingMan mentioned this pull request Feb 8, 2023
Merged
LingMan
LingMan approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@LingMan LingMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry about that. The changes look good. I've opened #117 to fix CI so this doesn't happen again.

@a8m a8m merged commit 5a44857 into a8m:master Feb 8, 2023
@AlyoshaVasilieva AlyoshaVasilieva deleted the windows branch February 8, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingMan LingMan LingMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlyoshaVasilieva @a8m @LingMan