adjust type definitions to allow browser usage #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyzerok
changed the title
|
I'm not 100% convinced (tbh I don't have the time right now to fully check) but after seeing your work on the vscode issue I trust you! |
|
I'll probably only be able to ship a new version next weekend, I'll still try to do it over the week though. |
|
Hello @aadsm and thanks a lot for merging! I based my type definition adjustments on the fact that you convert to the string internally. Also you are using strings in your tests and in your readme. Does this sound sensible? |
|
Oh I see, yeah. Thanks for pointing out the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Current type definitions expect
Buffer, however implementation does not require it. Since the library supports browsers, type definitions need to be more relaxed to allow browser usage without compilation errors :)