Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json [Bug fixing] #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rockyessel
Copy link

[error message]: The package may have incorrect main/module/exports specified in its package.json

[solution]: "browser": "dist/jsmediatags.min.js",

[Description]: In the package.json, the browser is supposed to have a "browser": "dist/jsmediatags.min.js", and not "browser": "dist/jsmediatags.js" to work well in the browser.

[error message]: The package may have incorrect main/module/exports specified in its package.json

[solution]: "browser": "dist/jsmediatags.min.js",

[Description]: In the package.json, the browser is supposed to have a "browser": "dist/jsmediatags.min.js", and not "browser": "dist/jsmediatags.js" to work well in the browser.
@eteeselink
Copy link

Thanks for making jsmediatags! I ran into the same problem and can confirm that the change in this PR fixes it.

With this fix, I can just do import * as jsmediatags from "jsmediatags" in my vite devserver and things Just Work. Without this change, I get errors all over.

@pedrohenriquebraga
Copy link

Please, merge it

@aShimoka
Copy link

aShimoka commented Feb 5, 2024

Will fix #172 when merged, bumping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants