fix 'quote' to optional field for openai compatibility assistant on FileCitation #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aallam
requested changes
Jun 22, 2024
openai-core/src/commonMain/kotlin/com.aallam.openai.api/message/MessageContent.kt
Outdated
Show resolved
Hide resolved
…e/MessageContent.kt Co-authored-by: Mouaad Aallam <Mouaad@Aallam.com>
aallam
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Change field 'quote' on com.aallam.openai.api.message.FileCitation nullable with no-value
What problem is this fixing?
In openai API for assistants module, api can't return type quote
Tested and works !