Fix the usage of type selector in :has() #57
Conversation
`descendants` function also includes text nodes, which causes `name node` function to fail down the line, because it only expects an ``Element of n`, not ``Text of string`, which a text node is. In any case, :has() doesn't select text nodes. So, excluding them beforehand is the way to go.
jbhoot
force-pushed
the
fix-simple-selector-in-has-argument
branch
from
df86095
to
596e776
Compare
|
@aantron I don't like that you have to spend time in cleaning up formatting everytime I make a PR. What formatter do you use? Can you also share your configuration for the same? |
|
Thank you!
I actually prefer to work this way, as it allows us to both work efficiently without unnecessary round-trips on minor matters. As long as you don't mind :) I don't use a formatter, as the formatters around as of last year made very illogical and diff-unfriendly choices. I opened some issues about that on ocamlformat, and I think there was some progress on this, but I haven't had time to check it yet. |
|
Whatever works for you is good enough for me. Thank you for the merge! |
The current implementation of
:has()selector does not exclude text nodes while selecting elements.Subsequently, during the parsing, these text nodes end up being passed to function
name node, which throws an error because it expects only element nodes.As a result, currently a selector like
:has(ul), which contains a type selector as its argument, fails.This PR fixes the aforementioned bug.
In the process, I also improved the assertion errors in the count tests, which now print,
expected: x but got: y, instead of justnot equals.