Skip to content

Commit

Permalink
GithubCI: upgrade actions to latest version
Browse files Browse the repository at this point in the history
Installing git before checkout was necessary to prevent this
error when git wants to interact with the checked out repo
(Probably because it's downloaded using Github's REST API):
```
fatal: not a git repository (or any parent up to mount point /)
```

Installing git before checkout also removes the problem with
using submodule parameter in checkout action so the comments we
had are no longer applicable.

This was done to fix errors we had with downloading actions [1].

[1] nblockchain#224 (comment)
  • Loading branch information
aarani committed Oct 19, 2023
1 parent 265b103 commit 0a03f2d
Showing 1 changed file with 48 additions and 44 deletions.
92 changes: 48 additions & 44 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
macOS--dotnet6-and-mono:
runs-on: macOS-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4.1.0
with:
submodules: false
- name: Setup .NET SDK 6.0.x
uses: actions/setup-dotnet@v1.7.2
uses: actions/setup-dotnet@v3.2.0
with:
dotnet-version: '6.0.113'
- name: configure
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:
macOS--mono-only:
runs-on: macOS-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4.1.0
with:
submodules: false
- name: HACK to emulate dotnet uninstall
Expand All @@ -67,7 +67,7 @@ jobs:
macOS--dotnet6-only:
runs-on: macOS-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4.1.0
with:
submodules: false
- name: HACK to emulate mono uninstall
Expand All @@ -90,11 +90,11 @@ jobs:
windows--dotnet6-and-legacyFramework:
runs-on: windows-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4.1.0
with:
submodules: false
- name: Setup .NET SDK 6.0.x
uses: actions/setup-dotnet@v1.7.2
uses: actions/setup-dotnet@v3.2.0
with:
dotnet-version: '6.0.113'
- name: configure
Expand Down Expand Up @@ -124,7 +124,7 @@ jobs:
windows--legacyFramework-only:
runs-on: windows-2019
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4.1.0
with:
submodules: false
- name: HACK to emulate dotnet uninstall
Expand All @@ -147,11 +147,11 @@ jobs:
windows--dotnet6-only:
runs-on: windows-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4.1.0
with:
submodules: false
- name: Setup .NET SDK 6.0.x
uses: actions/setup-dotnet@v1.7.2
uses: actions/setup-dotnet@v3.2.0
with:
dotnet-version: '6.0.113'
- name: HACK to emulate legacy .NETFramework uninstall
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
linux-github--dotnet-and-mono:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4.1.0
with:
submodules: false
- name: install missing dependencies
Expand All @@ -208,7 +208,7 @@ jobs:
linux-github--dotnet-and-newmono:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4.1.0
with:
submodules: false
- name: install missing dependencies
Expand Down Expand Up @@ -240,19 +240,17 @@ jobs:
container:
image: "ubuntu:22.04"
steps:
- uses: actions/checkout@v1
# can't use the option below because of error "Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH."
# with:
# submodules: 'true'

- name: install sudo
run: apt update && apt install --yes sudo
- name: install git
run: sudo apt install --yes git
- uses: actions/checkout@v4.1.0
- name: install all dependencies
run: |
# needed by fsx submodule
sudo apt install --yes curl
sudo DEBIAN_FRONTEND=noninteractive apt install --yes git make fsharp nunit-console
sudo DEBIAN_FRONTEND=noninteractive apt install --yes make fsharp nunit-console
# workaround for https://github.com/actions/runner/issues/2033
- name: ownership workaround
Expand Down Expand Up @@ -280,15 +278,16 @@ jobs:
container:
image: "ubuntu:22.04"
steps:
- uses: actions/checkout@v1
# can't use the option below because of error "Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH."
# with:
# submodules: 'true'

- name: install sudo
run: apt update && apt install --yes sudo
- name: install git
run: sudo apt install --yes git
- uses: actions/checkout@v4.1.0
# Cloning with submodules cause fsxc to try compiling fsx test scripts and fail
# with:
# submodules: 'true'
- name: install all dependencies
run: sudo DEBIAN_FRONTEND=noninteractive apt install --yes git make dotnet6
run: sudo DEBIAN_FRONTEND=noninteractive apt install --yes make dotnet6

# workaround for https://github.com/actions/runner/issues/2033
- name: ownership workaround
Expand Down Expand Up @@ -322,15 +321,16 @@ jobs:
container:
image: "ubuntu:22.04"
steps:
- uses: actions/checkout@v1
# can't use the option below because of error "Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH."
# with:
# submodules: 'true'

- name: install sudo
run: apt update && apt install --yes sudo
- name: install git
run: sudo apt install --yes git
- uses: actions/checkout@v4.1.0
# Cloning with submodules cause fsxc to try compiling fsx test scripts and fail
# with:
# submodules: 'true'
- name: install all dependencies
run: sudo DEBIAN_FRONTEND=noninteractive apt install --yes git make dotnet6
run: sudo DEBIAN_FRONTEND=noninteractive apt install --yes make dotnet6
- name: install last version of mono (Microsoft APT repositories)
run: sudo ./scripts/install_mono_from_microsoft_deb_packages.sh

Expand Down Expand Up @@ -366,15 +366,17 @@ jobs:
container:
image: "ubuntu:22.04"
steps:
- uses: actions/checkout@v1
# can't use the option below because of error "Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH."
- name: install sudo
run: apt update && apt install --yes sudo
- name: install git
run: sudo apt install --yes git
- uses: actions/checkout@v4.1.0
# Cloning with submodules cause fsxc to try compiling fsx test scripts and fail
# with:
# submodules: 'true'

- name: install sudo
run: apt update && apt install --yes sudo
- name: install all dependencies
run: sudo DEBIAN_FRONTEND=noninteractive apt install --yes git make dotnet6 mono-xbuild fsharp
run: sudo DEBIAN_FRONTEND=noninteractive apt install --yes make dotnet6 mono-xbuild fsharp
- name: install GTK libs (dependency of GTK frontend)
run: sudo apt install --yes libgtk2.0-cil-dev
# workaround for https://github.com/actions/runner/issues/2033
Expand Down Expand Up @@ -409,15 +411,13 @@ jobs:
container:
image: "ubuntu:22.04"
steps:
- uses: actions/checkout@v1
# can't use the option below because of error "Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH."
# with:
# submodules: 'true'

- name: install sudo
run: apt update && apt install --yes sudo
- name: install git
run: sudo apt install --yes git
- uses: actions/checkout@v4.1.0
- name: install all dependencies
run: sudo DEBIAN_FRONTEND=noninteractive apt install --yes git make fsharp nunit-console
run: sudo DEBIAN_FRONTEND=noninteractive apt install --yes make fsharp nunit-console
- name: install last version of mono (Microsoft APT repositories)
run: sudo ./scripts/install_mono_from_microsoft_deb_packages.sh

Expand Down Expand Up @@ -465,15 +465,19 @@ jobs:
- macOS--dotnet6-only

steps:
- uses: actions/checkout@v1
- name: install sudo
run: which sudo 2>/dev/null || (apt update && apt install --yes sudo)
- name: install git
run: sudo apt install --yes git
- uses: actions/checkout@v4.1.0
with:
submodules: false
fetch-depth: 0
- name: Install dependencies of commitlint
run: |
which sudo 2>/dev/null || (apt update && apt install --yes sudo)
sudo apt update
sudo apt install --yes git npm curl
sudo apt install --yes npm curl
sudo npm install --global n
sudo n lts
# workaround for https://github.com/actions/runner/issues/2033
Expand All @@ -497,7 +501,7 @@ jobs:

runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4.1.0
- name: Install snap tools
run: |
sudo apt update
Expand Down

0 comments on commit 0a03f2d

Please sign in to comment.