Editor: Fixed script editor title out-of-sync (mrdoob#28413)

* sync script editor title * no dispatching editScript, setValue is enough
aardgoose · May 18, 2024 · a379e9a · a379e9a
1 parent 6955746
commit a379e9a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/editor/js/Script.js b/editor/js/Script.js
@@ -429,6 +429,26 @@ function Script( editor ) {
 
 	} );
 
+	signals.objectChanged.add( function ( object ) {
+
+		if ( object === currentObject ) {
+
+			title.setValue( currentObject.name + ' / ' + currentScript.name );
+
+		}
+
+	} );
+
+	signals.scriptChanged.add( function ( script ) {
+
+		if ( script === currentScript ) {
+
+			title.setValue( currentObject.name + ' / ' + currentScript.name );
+
+		}
+
+	} );
+
 	return container;
 
 }

diff --git a/editor/js/commands/SetScriptValueCommand.js b/editor/js/commands/SetScriptValueCommand.js
@@ -31,15 +31,15 @@ class SetScriptValueCommand extends Command {
 
 		this.script[ this.attributeName ] = this.newValue;
 
-		this.editor.signals.scriptChanged.dispatch();
+		this.editor.signals.scriptChanged.dispatch( this.script );
 
 	}
 
 	undo() {
 
 		this.script[ this.attributeName ] = this.oldValue;
 
-		this.editor.signals.scriptChanged.dispatch();
+		this.editor.signals.scriptChanged.dispatch( this.script );
 
 	}