Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling and Rotation of PixImages #42

Open
luithefirst opened this issue Jan 10, 2020 · 2 comments
Open

Scaling and Rotation of PixImages #42

luithefirst opened this issue Jan 10, 2020 · 2 comments

Comments

@luithefirst
Copy link
Member

Aardvark.Base leaves the following functions for Scaling and Rotation of PixImages up for the library user to be initialized:
s_scaledFun using SetScaledFun
s_rotatedFun using SetRotatedFun
s_remappedFun using SetRemappedFun

  1. We should add meaningful error messages if these functions are not initialized.
  2. We should add out-of-the-box implementation without any 3rd party dependencies (would make the error message obsolete).
    I just recently implementation a "Scaled" function in "Tests\Aardvark.Base.Tests\Images\PixImageTests.cs" that could be used a start.

NOTE: A High-Performance implementation can be installed using the Aardvark.VRVis.Images library that uses IPPI Tensor extensions.

@krauthaufen
Copy link
Member

Hey, maybe we should just implement these things using our native-tensors.
Linear downsampling is already implemented, but the bicubic/lanczos filters are not...
It's a little odd anyways that PixImage has the API when it doesn't actually work.

hyazinthh added a commit that referenced this issue Oct 19, 2022
@hyazinthh
Copy link
Member

Added a default implementation for scaling based on @luithefirst 's implementation. Also these functions throw a proper exception now, if they are invoked and haven't been set.

hyazinthh added a commit to aardvark-platform/aardvark.data that referenced this issue May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants